-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
starrysystems.js.org #9667
starrysystems.js.org #9667
Conversation
lakshinhemachandran
commented
Mar 31, 2025
•
edited
Loading
edited
- There is reasonable content on the page (see: No Content)
- I have read and accepted the Terms and Conditions
- The site content can be seen at
Update cnames_active.js
@@ -38,6 +38,7 @@ | |||
*/ | |||
|
|||
var cnames_active = { | |||
"starrysystems": "starry-systems.github.io", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"starrysystems": "starry-systems.github.io", | |
"starrysystems": "starry-systems.github.io/website", |
If you're wanting to target https://github.com/Starry-Systems/website, then you need to include that path here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, as the CI (and the file itself) notes, your entry needs to be added in alphabetical order, please.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also also, https://github.com/Starry-Systems/website is not content that we're going to accept in its current state -- it is very clearly just placeholder content: https://github.com/Starry-Systems/website/blob/7f14547c10ff45e76d7029fee429ef7816d416aa/index.html
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok.
As stated in the readme I'm not accepting requests for pages without content. I´m going to close this but feel free to open a new PR when your page is ready for the public. |