Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

starrysystems.js.org #9667

Closed
wants to merge 2 commits into from
Closed

Conversation

lakshinhemachandran
Copy link

@lakshinhemachandran lakshinhemachandran commented Mar 31, 2025

The site content is ...
starry-systems.github.io/website

@MattIPv4 MattIPv4 changed the title Create starrysystems.js.org starrysystems.js.org Mar 31, 2025
@@ -38,6 +38,7 @@
*/

var cnames_active = {
"starrysystems": "starry-systems.github.io",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"starrysystems": "starry-systems.github.io",
"starrysystems": "starry-systems.github.io/website",

If you're wanting to target https://github.com/Starry-Systems/website, then you need to include that path here

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, as the CI (and the file itself) notes, your entry needs to be added in alphabetical order, please.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also also, https://github.com/Starry-Systems/website is not content that we're going to accept in its current state -- it is very clearly just placeholder content: https://github.com/Starry-Systems/website/blob/7f14547c10ff45e76d7029fee429ef7816d416aa/index.html

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok.

@indus indus added the no content This PR has a target that contains no valid content for a request label Apr 2, 2025
@indus
Copy link
Member

indus commented Apr 2, 2025

As stated in the readme I'm not accepting requests for pages without content. I´m going to close this but feel free to open a new PR when your page is ready for the public.

@indus indus closed this Apr 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid no content This PR has a target that contains no valid content for a request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants