-
Notifications
You must be signed in to change notification settings - Fork 35
Fix CI cargo version by pinning it to 1.88.0 #300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
zzorba
wants to merge
10
commits into
main
Choose a base branch
from
fix_ci_cargo_version
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
8890e7f
Fix CI cargo version by pinning it to 1.88.0
zzorba a1aa7fc
Pin rust version
zzorba f69b20b
Install rust manually
zzorba bc60506
Install rust fmt
zzorba b223ca2
Shell bash
zzorba 0982e7c
Move where we install rust fmt
zzorba 220b0fe
Add clippy to the mix
zzorba e630de9
Back out 1.88.0 vs stable change
zzorba 8e951c4
Pin just lint at 1.88.0
zzorba fa4c08d
Remove uneeded change
zzorba File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -16,6 +16,13 @@ jobs: | |
| steps: | ||
| - uses: actions/checkout@v4 | ||
|
|
||
| - name: Install Rust | ||
| uses: dtolnay/[email protected] | ||
|
|
||
| - name: Install Rust Fmt and Clippy | ||
| shell: bash | ||
| run: rustup component add rustfmt clippy | ||
|
|
||
| - name: Install clang-format | ||
| run: sudo apt-get install -y clang-format | ||
|
|
||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we want to also enforce this outside the CI, we could use the
rust-toolchain.tomlfile. If I understand the documentation correctly,rustupshould then automatically install / pick the specified version when commands are issued.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, we don't have that flow in this repo just yet... where would I add it? @jhugman curious to get your thoughts on this also.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's just a file at the repo level and rustup should use it automatically. I've never used it myself so far though. Not a real issue. Was just a thought.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think @Johennes is right; if we don't want to do that, then we can put it in the manifest.