-
Notifications
You must be signed in to change notification settings - Fork 35
Fix CI cargo version by pinning it to 1.88.0 #300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
605b32b to
a1aa7fc
Compare
| - name: Install Rust | ||
| uses: dtolnay/[email protected] | ||
|
|
||
| - name: Install Rust Fmt and Clippy | ||
| shell: bash | ||
| run: rustup component add rustfmt clippy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we want to also enforce this outside the CI, we could use the rust-toolchain.toml file. If I understand the documentation correctly, rustup should then automatically install / pick the specified version when commands are issued.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, we don't have that flow in this repo just yet... where would I add it? @jhugman curious to get your thoughts on this also.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's just a file at the repo level and rustup should use it automatically. I've never used it myself so far though. Not a real issue. Was just a thought.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think @Johennes is right; if we don't want to do that, then we can put it in the manifest.
jhugman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think now that @Johennes has fixed the other issues, this should build cleanly. Good work team!
No description provided.