Free memory allocated by base64_encode() #442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, good catch! |
paleolimbot
added a commit
to apache/arrow-nanoarrow
that referenced
this pull request
Jul 9, 2024
There are a few problems in the verification workflow: - On Windows, we weren't exporting any symbols in the C data integration test (when building with CMake) - The R package testthat doesn't seem to support centos7, which we would need to test the R package there - The R package jsonlite seems to leak memory. One fix is jeroen/jsonlite#442 , but in the meantime we can ignore the leak since it doesn't come from us.
|
@jeroen Are there any plans to release a version containing this PR in the near future? We still have a suppression in our CI to account for this and I would love to be able to remove it 🙂 |
|
ok it is on cran now. |
|
Thank you! |
paleolimbot
pushed a commit
to apache/arrow-nanoarrow
that referenced
this pull request
Sep 24, 2024
…ite release (#580) This suppression was annotated "Can be removed when jeroen/jsonlite#442 is released". This PR can serve as a placeholder for that until it is released
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This showed up in nanoarrow's CI: https://github.com/apache/arrow-nanoarrow/actions/runs/9823176470/job/27120757486#step:4:3425
For both encoding and decoding it looks like the pointers will leak if the following R allocation fails (probably unlikely with the size of raw vectors usually encoded/decoded, though).