Skip to content

fix(ci): Fix verification workflow #552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 9, 2024

Conversation

paleolimbot
Copy link
Member

@paleolimbot paleolimbot commented Jul 9, 2024

There are a few problems in the verification workflow:

  • On Windows, we weren't exporting any symbols in the C data integration test (when building with CMake)
  • The R package testthat doesn't seem to support centos7, which we would need to test the R package there
  • The R package jsonlite seems to leak memory. One fix is Free memory allocated by base64_encode() jeroen/jsonlite#442 , but in the meantime we can ignore the leak since it doesn't come from us.

@paleolimbot paleolimbot force-pushed the fix-verification-workflows branch from 62d28d4 to e5ef8f6 Compare July 9, 2024 18:16
@paleolimbot paleolimbot marked this pull request as ready for review July 9, 2024 23:56
@paleolimbot paleolimbot merged commit 2aa2e69 into apache:main Jul 9, 2024
33 checks passed
@paleolimbot paleolimbot deleted the fix-verification-workflows branch September 17, 2024 17:58
@paleolimbot paleolimbot added this to the nanoarrow 0.6.0 milestone Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant