Skip to content

[#440] Delete deprecated symbols incorporating "UserGroup" as substring #745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[#440] Delete deprecated symbols incorporating "UserGroup" as substring #745

wants to merge 1 commit into from

Conversation

d-w-moore
Copy link
Collaborator

No description provided.

@d-w-moore
Copy link
Collaborator Author

Still need to run all tests on this

alanking
alanking reviewed Jun 26, 2025
View reviewed changes
Copy link
Contributor

@alanking alanking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's be more specific in the commit message about what is being removed here. Otherwise, changes look good.

I had one question but I think I answered it myself. Just wanted to confirm.

alanking
alanking reviewed Jun 27, 2025
View reviewed changes
Copy link
Contributor

@alanking alanking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than commit message update as previously suggested, saw one more thing that could perhaps be improved.

alanking
alanking reviewed Jun 27, 2025
View reviewed changes
Copy link
Contributor

@alanking alanking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's all from me... Perhaps ready for squashing and updating commit message, pending any tests which may or may not need running.

@d-w-moore
[_440] remove symbols that reference "user groups"
e1789a3 
Originally, PRC models, objects, variables, etc., that had to do with groups of iRODS
users referred to them as "user groups."  The extra verbosity was intended to distinguish
them from the (no longer extant) resource groups.

In v1.1.7, when groupadmin capabilities were being upgraded, we also
introduced new symbol aliases that referred to a "UserGroups" as simply a "Group" and
deprecated the use of the old symbols. As a side benefit, some of the new symbols
were tailored to allow a "groupadmin" transparent access to their special
capabilites whenever the group_admin parameter was allowed to naturally default.)

The deprecated older symbols are hereby removed.
@d-w-moore
Copy link
Collaborator Author

That's all from me... Perhaps ready for squashing and updating commit message, pending any tests which may or may not need running.

done!

@d-w-moore
Copy link
Collaborator Author

(the squashing/ commit message rewrite, and some of the testing).

alanking
alanking approved these changes Jun 27, 2025
View reviewed changes
Copy link
Contributor

@alanking alanking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I say # it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trel trel trel left review comments

@alanking alanking alanking approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@d-w-moore @trel @alanking