review change: remove walrus operator and shortcut-logic induced bugs

Author: d-w-moore

irods/manager/user_manager.py

@@ -293,12 +293,11 @@ def create(
         group_admin=None,
         **options,
     ):
+        user_zone = options.pop("user_zone", "")
+        auth_str = options.pop("auth_str", "")
+        user_type = options.pop("user_type", "rodsgroup")
 
-        if (
-            (user_zone := options.pop("user_zone", "")) != ""
-            or (auth_str := options.pop("auth_str", "")) != ""
-            or (user_type := options.pop("user_type", "rodsgroup")) != "rodsgroup"
-        ):
+        if user_zone != "" or auth_str != "" or user_type != "rodsgroup":
             warnings.warn(
                 "Use of non-default value for auth_str, user_type or user_zone in GroupManager.create is deprecated",
                 DeprecationWarning,