-
-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
66 generate server client #67
66 generate server client #67
Conversation
@baronfel This is ready to review. |
<Exec Command="dotnet tool restore" WorkingDirectory="$(MSBuildThisFileDirectory)" | ||
StandardOutputImportance="High" StandardErrorImportance="High" /> | ||
<MakeDir Directories="$(_BuildProjBaseIntermediateOutputPath)" /> | ||
<Touch Files="$(_DotnetToolRestoreOutputFile)" AlwaysCreate="True" ForceTouch="True" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion: Add $(_DotnetToolRestoreOutputFile)
to the FileWrites
Item so that dotnet clean
will remove it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added, just double check if this is the proper way to do it.
<_GenerateCommand2 Include="%(_MetaModelClientServerOutputs.FullPath)" /> | ||
</ItemGroup> | ||
|
||
<Exec |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After this, add @(_MetaModelClientServerOutputs)
to FileWrites
for cleanup?
Doing an API-diff now to see what's changed on |
Here's the generated diff: API Changes:
|
Ok - most of the changes by volume are adding Freaking awesome groundwork here mate. |
WHAT
#66
WHY
Keep the Types and Server/Client in sync
HOW
copilot:walkthrough