datastream: add basic OS logging #82
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrcastro2
force-pushed
the
add-datastream-logging
branch
3 times, most recently
from
76b7514 to
38e403e
Compare
* Introduced `LogManager` to handle structured logging via registered builders. * Added `SearchBackend` to store logs in a search engine (OpenSearch/Elasticsearch). * Implemented `LogEvent` for structured log representation. * Enabled dynamic log builder registration via entry points. * Integrated Celery task (`log_event_task`) to handle asynchronous log ingestion. * Ensured template validation in the search engine before indexing logs. * Configurable log types to support audit, job and others. * closes CERNDocumentServer/cds-rdm#361 Co-authored-by: Saksham Arora <[email protected]>
jrcastro2
force-pushed
the
add-datastream-logging
branch
from
38e403e to
dd5b5a3
Compare
jrcastro2
force-pushed
the
add-datastream-logging
branch
from
aa36d2b to
8f0e0e0
Compare
jrcastro2
commented
Mar 6, 2025
invenio_logging/datastreams/templates/os-v1/datastream-log-v1.0.0.json
Outdated
Show resolved
Hide resolved
jrcastro2
commented
Mar 6, 2025
|
Add the resource for the logs, to be checked |
kpsherva
reviewed
Mar 7, 2025
| @@ -35,3 +35,9 @@ def search(cls, query): | |||
| """Search logs.""" | |||
| results = cls.backend_cls().search(query) | |||
| return cls.schema.dump(results, many=True) | |||
|
|
|||
| @classmethod | |||
| def list(cls): | |||
There was a problem hiding this comment.
how is list different from search?
kpsherva
reviewed
Mar 7, 2025
| @@ -89,7 +89,7 @@ def search(self, query=None, size=10): | |||
| "operator": "and", | |||
| } | |||
| }, | |||
| "sort": [{"timestamp": {"order": "desc"}}], | |||
| "sort": [{"@timestamp": {"order": "desc"}}], | |||
There was a problem hiding this comment.
I think this whole method should be in a log dedicated service class
this should probably not be in this module.
could work as a prototype now, but it should be moved in the next iteration to a service - also because we are missing the permissions completely here.
Probably even before finalising the frontend, otherwise you will end up patching a lot of things.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: CERNDocumentServer/cds-rdm#361