Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

logging: adds datastream logging #70

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

logging: adds datastream logging #70

wants to merge 1 commit into from

Conversation

jrcastro2
Copy link

@jrcastro2 jrcastro2 commented Mar 6, 2025 •
edited
Loading

jrcastro2
jrcastro2 commented Mar 6, 2025
View reviewed changes
invenio_jobs/logging/__init__.py
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The type should be application instead of job. To be used by any other logging produced by the app (that is not audit logs). Consider moving this somewhere more core than invenio-jobs

jrcastro2
jrcastro2 commented Mar 6, 2025
View reviewed changes
invenio_jobs/logging/builders.py

class JobLogBuilder(LogBuilder):
"""Builder for structured job logs."""

Copy link
Author

@jrcastro2 jrcastro2 Mar 6, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Out of scope for now: Consider adding context_processors with information useful to debug, such as host, ipaddress ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add all backend needed for logging for jobs runs
1 participant
@jrcastro2