Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue#434 speedTime 아이템의 매커니즘 변경 해결 #437

Merged
merged 2 commits into from
Apr 18, 2018

Conversation

Ochodus
Copy link

@Ochodus Ochodus commented Apr 16, 2018

speedTime 아이템의 스피드 증가량을 대폭 낮추고 최대 4번까지 중첩되도록 변경. 대신 지속시간 소폭 상승. slowTime 아이템의 경우 정상적으로 작동하고 프레임 드랍은 다른 원인이 있는 걸로 생각되어 변경 하지 않음. 또한 speedTime의 지속시간 경과 후 원래 속도 회복 방식 변경.

@Ochodus Ochodus changed the title issuespeedTime 아이템의 매커니즘 변경 issue#433 speedTime 아이템의 매커니즘 변경 해결 Apr 16, 2018
@StillnessFate StillnessFate added enhancement New feature or request Action Game action related Game design Game design team and removed Action Game action related labels Apr 16, 2018
@StillnessFate
Copy link
Collaborator

StillnessFate commented Apr 16, 2018

이 PullRequest의 수정사항은 이슈 #433 과 큰 연관성이 없는 것 같습니다. 다른 이슈를 잘못 연결한 것 아닌가요?
제가 보기에는 #434 이슈인 것 같습니다.

@Taewan-P Taewan-P added this to the Week 6 milestone Apr 16, 2018
@Ochodus Ochodus changed the title issue#433 speedTime 아이템의 매커니즘 변경 해결 issue#434 speedTime 아이템의 매커니즘 변경 해결 Apr 17, 2018
@Ochodus
Copy link
Author

Ochodus commented Apr 17, 2018

실수로 번호를 착각한거 같네요... 수정했습니다.

@inureyes inureyes requested a review from moonkihun April 18, 2018 05:15
@inureyes inureyes added the score:5 Score label Apr 18, 2018
@inureyes inureyes merged commit a37b5db into inureyes:master Apr 18, 2018
jaeheeLee17 added a commit to jaeheeLee17/Galtron that referenced this pull request Apr 18, 2018
* inureyes#406 (inureyes#422)

* Issues inureyes#269 세팅메뉴에 intercept 버튼추가, 플레이중 esc 누를시 게임종료할건지 한번 더 물어봄 (inureyes#421)

* 세팅메뉴에 intercept 버튼추가, 플레이중 esc 누를 시 게임종료 할껀지 한번 더 물어봄
* charge, ultimate, life 글씨 추가

* refs inureyes#444 : modify - wrong README.md

* Resolved inureyes#430 (inureyes#431)

* license for sounds added
* some mistakes
* - Added new bullets. COOOOOL!
Thanks to Bonsaiheldin. See this : https://opengameart.org/content/sci-fi-space-simple-bullets
- Moved unnecessary gfx files to another folder 'old_gfx' (But not all)

* refs inureyes#430 : bugfix - typo

* speedTime 아이템의 매커니즘 변경 (inureyes#437)

* 일부 들여쓰기 일관성 문제 수정 (inureyes#439)

* Rebase

* Fix incorrect indentation

* issue#385 아이템의 위력 세분화 해결 (inureyes#438)

* speedTime 아이템의 매커니즘 변경

* 크기에 따라 위력이 달라지도록 아이템 작동 방식 변경. 그에 따른 아이템의 위력 조정.

* inureyes#432 Bug is fixed (inureyes#436)

* inureyes#432 bug is fixed

* refs inureyes#436 : bugfix - missing variable

* Fix README.md: inureyes#444 (inureyes#445)

* charge, ultimate, life 글씨 추가

* README.md fix

마크다운 문법에 알맞게 수정하였습니다.

* resolved inureyes#387(no conflict) (inureyes#427)

* resolved inureyes#387

*  * modify - naming scheme to know the difference between invincibility
 and shield

* resolve inureyes#393, inureyes#398 issue (inureyes#411)

* remodify code for issue inureyes#393, inureyes#398

* refs inureyes#411, inureyes#398 : bugfix - revert some of eafb56e which disables speed
setting on menu.
 * When you delete others' code, review and understand first.

* refs inureyes#411  : bugfix - wrong rollback / reference

*  * Modify indentations

* refs inureyes#411  : bugfix - when self.Limit = 0, alien / fleetDrop stops.
bean3 added a commit to bean3/Galtron that referenced this pull request Apr 19, 2018
* 'master' of https://github.com/inureyes/Galtron: (205 commits)
  Revert "Merge branch 'master' into master"
  refs inureyes#411  : bugfix - when self.Limit = 0, alien / fleetDrop stops.
  * Modify indentations
  refs inureyes#411  : bugfix - wrong rollback / reference
  refs inureyes#411, inureyes#398 : bugfix - revert some of eafb56e which disables speed setting on menu.  * When you delete others' code, review and understand first.
  resolve inureyes#393, inureyes#398 issue (inureyes#411)
  * modify - naming scheme to know the difference between invincibility  and shield
  resolved inureyes#387(no conflict) (inureyes#427)
  Fix README.md: inureyes#444 (inureyes#445)
  refs inureyes#436 : bugfix - missing variable
  inureyes#432 Bug is fixed (inureyes#436)
  issue#385 아이템의 위력 세분화 해결 (inureyes#438)
  일부 들여쓰기 일관성 문제 수정 (inureyes#439)
  speedTime 아이템의 매커니즘 변경 (inureyes#437)
  refs inureyes#430 : bugfix - typo
  Resolved inureyes#430 (inureyes#431)
  refs inureyes#444 : modify - wrong README.md
  Issues inureyes#269 세팅메뉴에 intercept 버튼추가, 플레이중 esc 누를시 게임종료할건지 한번 더 물어봄 (inureyes#421)
  inureyes#406 (inureyes#422)
  Rebase
  ...

# Conflicts:
#	alien.py
#	gameFunctions.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Game design Game design team score:5 Score
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants