Skip to content

fix: remove fixed popup height to prevent scrollbar at high zoom #1211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix: remove fixed popup height to prevent scrollbar at high zoom #1211

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c08af5f
fix: remove fixed popup height to prevent scrollbar at high zoom
ARYPROGRAMMER Oct 20, 2025
43c28bb
Merge branch 'main' into fix/popup-scrollbar-zoom
ARYPROGRAMMER Oct 20, 2025
780586f
static fixture
ARYPROGRAMMER Oct 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions src/pages/popup/components/layout/MainLayout.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,16 +2,19 @@ import React from 'react';
import { Header } from './Header';

const Divider = () => {
return <div className="w-100 h-1 bg-divider-gradient" />;
return <div className="w-full h-px bg-divider-gradient" />;
};

export const MainLayout = ({ children }: { children: React.ReactNode }) => {
return (
// biome-ignore lint/correctness/useUniqueElementIds: main is unique, as at top-level layout
<div className="flex h-popup w-popup flex-col gap-4 px-6 py-4" id="main">
<div
id="main"
className="flex w-popup min-h-[480px] min-w-[360px] max-h-[90vh] h-auto flex-col gap-4 px-6 py-4 overflow-hidden"
>
<Header />
<Divider />
<main className="flex flex-1 flex-col">{children}</main>
<main className="flex flex-1 flex-col overflow-y-auto">{children}</main>
</div>
);
};
}