-
Notifications
You must be signed in to change notification settings - Fork 9
fix: remove fixed popup height to prevent scrollbar at high zoom #1211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
fix: remove fixed popup height to prevent scrollbar at high zoom #1211
Conversation
Signed-off-by: Arya Pratap Singh <[email protected]>
|
such a simple change it was and worked like a charm for review: @sidvishnoi |
sidvishnoi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The problem with removing the height like this means the extension popup will keep changing size based on content, which isn't a user good experience.
Screen.Recording.2025-10-21.at.14.12.38.mov
Signed-off-by: Arya Pratap Singh <[email protected]>
the other fix would involve some or the other hardcoded things, even though the connect button is dynamically positioned it would be the most optimal change [maybe add the button to the top]. in any case i am doing another change this is also good and solves the problem. @sidvishnoi did the changes |
|
@ARYPROGRAMMER I see in the wallet info screen, there's a scrollbar even without browser zoom when the advanced section is open, and the overall UI looks squished.
Also, note info/warning pages have content moved to top instead of center: I'm not sure of the way forward here. I have asked the team for some design direction. Meanwhile, would you like to work on some other issues? 1187 and 1188 are good options - I can assign either to you if you comment on those issues. |
|
yes pls you can assign me both @sidvishnoi ,the problem with this is that the design might be too complicated or might need re refractoring of the mainlayout for that per say. I still think h-popup removal was the easiest and comfortable thing to do but yes surely let's come back to this later |


Context
Popup has scrollbar when browser zoom >100%.
The popup uses a fixed height constraint that doesn't accommodate content scaling at zoom levels above 100%, causing unwanted scrollbars. This affects usability across different browsers and devices.
Closes #1014
Changes proposed in this pull request
Remove the fixed h-popup height class from the MainLayout component to enable dynamic popup sizing based on content height. This ensures the popup window resizes automatically to fit content at all zoom levels without scrollbars.
Modified MainLayout.tsx to remove h-popup class from the root div