Im 542 get s3 region by analyzing the asset href #224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As we need to check the protocol for href, we cannot rely on this extension anymore.
| } catch (Exception e) { | ||
| System.err.println("Exception testing region " + region + ": " + e.getMessage()); | ||
| // Continue testing other regions if the bucket is not found | ||
| continue; |
There was a problem hiding this comment.
This catch is very general, could it be interesting to write a warning to the log file?
There was a problem hiding this comment.
I am not sure about adding the logging class here, as the loop will fail most times. I could manage the exceptions in a more specialized way.
| return resolvedRegion; | ||
|
|
||
| } catch (Exception e) { | ||
| System.err.println("Failed to resolve region dynamically for bucket: " + bucketName + ". Error: " + e.getMessage()); | ||
| // try another one |
There was a problem hiding this comment.
This catch is very general, could it be interesting to write a warning to the log file?
Added mock for Monitor
euskalhenriko
approved these changes
Jan 31, 2025
inigo-cobian
deleted the
IM-542-Get-S3-region-by-analyzing-the-asset-href
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog:
item_assetscompatibility, as it lacked thehreffield needed for getting the bucket.s3BucketRegiontoawsRegionand removed it as a parameter at the importer.