Update S3RegionResolverTest

Added mock for Monitor
integratedmodelling · Feb 3, 2025 · 07a89f6 · 07a89f6
1 parent e9af121
commit 07a89f6
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 3 deletions.
diff --git a/klab.engine/pom.xml b/klab.engine/pom.xml
@@ -960,6 +960,12 @@
 				<version>${junit5.version}</version>
 				<scope>test</scope>
 			</dependency>
+			<dependency>
+				<groupId>org.mockito</groupId>
+				<artifactId>mockito-core</artifactId>
+				<version>${mockito.version}</version>
+				<scope>test</scope>
+			</dependency>
 		<!--- AWS dependencies-->
 		<dependency>
 			<artifactId>apache-client</artifactId> 

diff --git a/klab.engine/src/test/java/org/integratedmodelling/klab/test/utils/S3RegionResolverTest.java b/klab.engine/src/test/java/org/integratedmodelling/klab/test/utils/S3RegionResolverTest.java
@@ -1,20 +1,22 @@
 package org.integratedmodelling.klab.test.utils;
 
+import org.integratedmodelling.klab.api.runtime.monitoring.IMonitor;
 import org.integratedmodelling.klab.exceptions.KlabResourceAccessException;
 import org.integratedmodelling.klab.utils.s3.S3RegionResolver;
 import org.junit.jupiter.api.Assertions;
 import org.junit.jupiter.api.Test;
+import org.mockito.Mockito;
 
 import software.amazon.awssdk.regions.Region;
 
 public class S3RegionResolverTest {
-
     @Test
     public void resolveBucketRegion_resolutionSuccessful() {
         String bucket = "deafrica-input-datasets";
         String objectKey = "rainfall_chirps_monthly/chirps-v2.0_2024.03.tif";
+        IMonitor monitor = Mockito.mock(IMonitor.class);
 
-        Region ret = S3RegionResolver.resolveBucketRegion(bucket, objectKey);
+        Region ret = S3RegionResolver.resolveBucketRegion(bucket, objectKey, monitor);
 
         Assertions.assertEquals(Region.AF_SOUTH_1, ret);
     }
@@ -24,9 +26,10 @@ public void resolveBucketRegion_resolutionSuccessful() {
     public void resolveBucketRegion_resolutionUnsuccessful() {
         String bucket = "fake-bucket";
         String objectKey = "fake-object.tif";
+        IMonitor monitor = Mockito.mock(IMonitor.class);
 
         Assertions.assertThrows(KlabResourceAccessException.class, () -> {
-            S3RegionResolver.resolveBucketRegion(bucket, objectKey);
+            S3RegionResolver.resolveBucketRegion(bucket, objectKey, monitor);
         });
     }