handle gripping case #4
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces enhancements to the
OnRobotGripper
class to improve the detection of gripper movement completion, including handling scenarios where the gripper stallsEnhancements to movement detection:
_last_known_position
and_last_position_change_time
to track the gripper's position and the last time it changed significantly (onrobot_gripper.hpp
)._last_known_position
and_last_position_change_time
when a new command is issued to ensure accurate tracking (onrobot_gripper.cpp
).Improvements to gripper movement logic:
onrobot_gripper.cpp
)._command_in_progress
flag is reset only when movement is confirmed as finished, either by reaching the target position or due to stalling (onrobot_gripper.cpp
).