fix(cat-gateway): Correct Service Health logic #1974
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…point and middleware
…point and middleware
saibatizoku
changed the title
This was referenced Mar 6, 2025
saibatizoku
added
do not merge yet
saibatizoku
force-pushed
the
fix/health-probe-logic
branch
from
30a233a to
3bf2daf
Compare
|
✅ Test Report | |
bkioshn
reviewed
Mar 10, 2025
| // TODO: find a better way to filter URI paths | ||
| if !req.uri().path().starts_with("/health") { | ||
| if !EventDB::connection_is_ok() { | ||
| set_index_db_liveness(false); |
There was a problem hiding this comment.
Should it be set_event_db_liveness?
There was a problem hiding this comment.
Thanks for the catch!
Mr-Leshiy
reviewed
Mar 14, 2025
apskhem
reviewed
Mar 18, 2025
apskhem
reviewed
Mar 18, 2025
…lower first syncs
bkioshn
reviewed
Mar 20, 2025
Comment on lines
+148
to
+156
| // Return 204 response if check passed initially. | ||
| if index_db_live && event_db_live { | ||
| return success_response; | ||
| } | ||
|
|
||
| // Otherwise, re-check, and return 204 response if all is good. | ||
| if index_db_is_live() && event_db_is_live() { | ||
| return success_response; | ||
| } |
There was a problem hiding this comment.
Why do we need the first check? if index_db_live && event_db_live { Can we do just if index_db_is_live() && event_db_is_live() {?
| /// Flag to determine if the service has started | ||
| static STARTED: AtomicBool = AtomicBool::new(false); | ||
|
|
||
| /// Flag to determine if the service has started. |
There was a problem hiding this comment.
Suggested change
| /// Flag to determine if the service has started. | |
| /// Flag to determine if the index db is lived. |
| /// Flag to determine if the service has started. | ||
| static LIVE_INDEX_DB: AtomicBool = AtomicBool::new(false); | ||
|
|
||
| /// Flag to determine if the service has started. |
There was a problem hiding this comment.
Suggested change
| /// Flag to determine if the service has started. | |
| /// Flag to determine if the event db is lived. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Logic is implemented as outlined in #1827.
Related Issue(s)
Closes #1827 .
Description of Changes
Provide a clear and concise description of what the pull request changes.
Breaking Changes
Describe any breaking changes and the impact.
Screenshots
If applicable, add screenshots to help explain your changes.
Related Pull Requests
#1921 , #1919
Please confirm the following checks