Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cat-gateway): Service Readiness check #1919

Closed

Conversation

saibatizoku
Copy link
Contributor

Description

Thanks for contributing to the project!
Please fill out this template to help us review your changes.

Related Issue(s)

List the issue numbers related to this pull request.

e.g., Closes #1, Resolves #1 Fixes #1

Description of Changes

Provide a clear and concise description of what the pull request changes.

Breaking Changes

Describe any breaking changes and the impact.

Screenshots

If applicable, add screenshots to help explain your changes.

Related Pull Requests

If applicable, list any related pull requests.

e.g., #1, #1

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

@saibatizoku saibatizoku added the do not merge yet PR is not ready to be merged yet label Feb 25, 2025
@saibatizoku saibatizoku self-assigned this Feb 25, 2025
@saibatizoku saibatizoku changed the base branch from main to fix/service-liveness-check February 25, 2025 22:27
@saibatizoku saibatizoku force-pushed the fix/service-readiness-check branch from 0cffca4 to 69686bd Compare February 25, 2025 22:37
Copy link
Contributor

Test Report | ${\color{lightgreen}Pass: 578/583}$ | ${\color{red}Fail: 0/583}$ |

@saibatizoku saibatizoku force-pushed the fix/service-readiness-check branch from 69686bd to 7ddb1bc Compare February 26, 2025 03:51
@saibatizoku saibatizoku changed the base branch from fix/service-liveness-check to fix/service-started-check February 26, 2025 03:52
Copy link
Contributor

Test Report | ${\color{lightgreen}Pass: 577/583}$ | ${\color{red}Fail: 1/583}$ |

Copy link
Contributor

Test Report | ${\color{lightgreen}Pass: 590/595}$ | ${\color{red}Fail: 0/595}$ |

Copy link
Contributor

Test Report | ${\color{lightgreen}Pass: 592/597}$ | ${\color{red}Fail: 0/597}$ |

Copy link
Contributor

github-actions bot commented Mar 4, 2025

Test Report | ${\color{lightgreen}Pass: 603/608}$ | ${\color{red}Fail: 0/608}$ |

@saibatizoku
Copy link
Contributor Author

Close in favor of #1974 .

@saibatizoku saibatizoku closed this Mar 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do not merge yet PR is not ready to be merged yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

First
1 participant