Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(rust/signed-doc): Add integration test validating all functionalities against the spec #229

Merged
merged 25 commits into from
Mar 18, 2025

Conversation

apskhem
Copy link
Collaborator

@apskhem apskhem commented Mar 5, 2025

Description

Added integration test to catalyst-signed-doc

  • Moved all tests inside lib.rs to tests/integration.rs with some refactoring.
  • Added validation test to both Proposal and Comment document. The test includes both valid and invalid cases.

Related Issue(s)

Closes #1863

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

@apskhem apskhem self-assigned this Mar 5, 2025
@apskhem apskhem marked this pull request as draft March 5, 2025 11:51
@apskhem apskhem changed the title test(rust/signed-doc): Add integration test validing all functionalities against the spec test(rust/signed-doc): Add integration test validating all functionalities against the spec Mar 5, 2025
Copy link
Contributor

github-actions bot commented Mar 6, 2025

Test Report | ${\color{lightgreen}Pass: 309/309}$ | ${\color{red}Fail: 0/309}$ |

@apskhem apskhem marked this pull request as ready for review March 13, 2025 09:59
@apskhem apskhem requested review from Mr-Leshiy, stevenj and saibatizoku and removed request for Mr-Leshiy March 13, 2025 09:59
@apskhem apskhem added the review me PR is ready for review label Mar 13, 2025
@apskhem apskhem requested a review from Mr-Leshiy March 17, 2025 09:55
Mr-Leshiy
Mr-Leshiy previously approved these changes Mar 17, 2025
Copy link
Contributor

@Mr-Leshiy Mr-Leshiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@Mr-Leshiy Mr-Leshiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Mr-Leshiy Mr-Leshiy enabled auto-merge (squash) March 18, 2025 08:21
@Mr-Leshiy Mr-Leshiy merged commit d1fc055 into main Mar 18, 2025
21 checks passed
@Mr-Leshiy Mr-Leshiy deleted the test/signed-docs branch March 18, 2025 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review me PR is ready for review
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Catalyst Signed Documents crate's integration tests
3 participants