Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catalyst Signed Documents crate's integration tests #1863

Closed
Mr-Leshiy opened this issue Feb 19, 2025 · 0 comments · Fixed by input-output-hk/catalyst-libs#229
Closed

Catalyst Signed Documents crate's integration tests #1863

Mr-Leshiy opened this issue Feb 19, 2025 · 0 comments · Fixed by input-output-hk/catalyst-libs#229
Assignees
Labels
rust Pull requests that update Rust code

Comments

@Mr-Leshiy
Copy link
Contributor

Mr-Leshiy commented Feb 19, 2025

Summary

For the catalyst-signed-doc crate add tests to cover all topics based on the spec

Description

Add a Rust integration tests for the catalyst-signed-doc crate, by adding them under signed_doc/tests dir.
Need to test our public API of the crate by the following sections:

  • Decoding tests (move and probably extend current catalyst_signed_doc_cbor_roundtrip_test test).
  • Signature validation (move and probably update current signature_verification_test test).
  • Validation tests (test pub async fn validate<Provider>( doc: &CatalystSignedDocument, provider: &Provider, ) -> anyhow::Result<bool>)
    • Proposal document tests (following the proposal document spec)
    • Comment document tests (following the comment document spec)

As a reference how to build and run this validation you can take a look for each rules unit test (catalyst-libs/rust/signed_doc/src/validator/rules)

@Mr-Leshiy Mr-Leshiy added the rust Pull requests that update Rust code label Feb 19, 2025
@apskhem apskhem moved this from New to 🏗 In progress in Catalyst Mar 4, 2025
@apskhem apskhem moved this from 🏗 In progress to 👀 In review in Catalyst Mar 13, 2025
@github-project-automation github-project-automation bot moved this from 👀 In review to 🔬 Ready For QA in Catalyst Mar 18, 2025
@apskhem apskhem moved this from 🔬 Ready For QA to ✅ Done in Catalyst Mar 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rust Pull requests that update Rust code
Projects
Archived in project
2 participants