Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add container tests to logging job #219

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Add container tests to logging job #219

wants to merge 5 commits into from

Conversation

elfiesmelfie
Copy link
Collaborator

@elfiesmelfie elfiesmelfie commented Jan 29, 2025 •
edited
Loading

Depends-On: #181
Depends-On: #204

Depends-On: #217
Depends-On: openstack-k8s-operators/telemetry-operator#621

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Merge Failed.

This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.
Warning:
Error merging github.com/infrawatch/feature-verification-tests for 181,7615cd4e5dea267106bfc2ce4276b683c0a6f449

@elfiesmelfie elfiesmelfie force-pushed the efoley_logging_add_container_tests branch from e69176a to 9f48e40 Compare January 30, 2025 16:17
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Merge Failed.

This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.
Warning:
Error merging github.com/infrawatch/feature-verification-tests for 181,25491b059bc675df47bc733ef5b7adce9c4fc4f2

vyzigold
vyzigold requested changes Feb 11, 2025
View reviewed changes
Copy link
Contributor

@vyzigold vyzigold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The container tests actually don't work. Ctrl+f "12753" in https://logserver.rdoproject.org/19/219/1b4cea67d9c116e3cbe6fdb4534d912ce6c989f5/github-c[…]er/ci-framework-data/logs/post_deploy_00_fvt_logging.log

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/1e384c144779453eabc47c91b9f21739

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 31m 50s
✔️ functional-tests-on-osp18 SUCCESS in 1h 27m 27s
❌ functional-logging-tests-osp18 FAILURE in 1h 12m 17s
✔️ functional-graphing-tests-osp18 SUCCESS in 1h 11m 24s
✔️ functional-metric-verification-tests-osp18 SUCCESS in 1h 18m 32s

@elfiesmelfie elfiesmelfie force-pushed the efoley_logging_add_container_tests branch from cbb561e to 9becdab Compare February 13, 2025 19:11
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/61fc2c9ea6dd4ed09fe5a372366a4c14

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 37m 35s
✔️ functional-tests-on-osp18 SUCCESS in 1h 24m 04s
❌ functional-logging-tests-osp18 FAILURE in 1h 10m 09s
✔️ functional-graphing-tests-osp18 SUCCESS in 1h 13m 39s
❌ functional-metric-verification-tests-osp18 FAILURE in 1h 10m 42s

@elfiesmelfie elfiesmelfie force-pushed the efoley_logging_add_container_tests branch from 9becdab to 80df810 Compare February 13, 2025 20:51
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/ee5d745c032f47e6957b89bd5eaea15e

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 39m 49s
✔️ functional-tests-on-osp18 SUCCESS in 1h 24m 21s
❌ functional-logging-tests-osp18 FAILURE in 1h 14m 25s
✔️ functional-graphing-tests-osp18 SUCCESS in 1h 14m 01s
✔️ functional-metric-verification-tests-osp18 SUCCESS in 1h 19m 26s

@elfiesmelfie elfiesmelfie force-pushed the efoley_logging_add_container_tests branch from 80df810 to 1879e3d Compare February 14, 2025 16:43
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/1a7397c8f7364bc1910a4a5bb51230d1

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 41m 17s
✔️ functional-tests-on-osp18 SUCCESS in 1h 25m 15s
❌ functional-logging-tests-osp18 FAILURE in 1h 12m 48s
✔️ functional-graphing-tests-osp18 SUCCESS in 1h 12m 39s
❌ functional-metric-verification-tests-osp18 FAILURE in 1h 13m 06s

@elfiesmelfie elfiesmelfie force-pushed the efoley_logging_add_container_tests branch from 1879e3d to 48bf764 Compare February 14, 2025 19:41
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/ceda1e1f11ee4f778d602deaa3511170

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 39m 15s
✔️ functional-tests-on-osp18 SUCCESS in 1h 24m 31s
❌ functional-logging-tests-osp18 FAILURE in 1h 11m 20s
✔️ functional-graphing-tests-osp18 SUCCESS in 1h 12m 22s
✔️ functional-metric-verification-tests-osp18 SUCCESS in 1h 16m 05s

@elfiesmelfie
[ci] Add container tests to the logging job
cfa5590 
The test check for the containers that should exist on the compute node.

Co-authored-by: "Alex Yefimov <[email protected]>"
@elfiesmelfie
[common] Update container tests
80e83ce 
Add an additional fail condition and make the fail_msg more verbose
Update the container tests to use elevated permissions
@elfiesmelfie
[common] Add debug to container tests when container is not found
78074c8
@elfiesmelfie elfiesmelfie force-pushed the efoley_logging_add_container_tests branch from 48bf764 to 56e5a08 Compare February 17, 2025 16:49
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/ac47a2b13a5a4113bd370ac37a7012cd

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 30m 00s
✔️ functional-tests-on-osp18 SUCCESS in 1h 24m 22s
❌ functional-logging-tests-osp18 FAILURE in 1h 10m 32s
❌ functional-graphing-tests-osp18 FAILURE in 1h 43m 11s
✔️ functional-metric-verification-tests-osp18 SUCCESS in 1h 19m 10s

@mgirgisf
Copy link
Contributor

I think to test the container "ceilometer_agent_ipmi" you need to enable the power_monitoring in the logging job

  • "@{{ ansible_user_dir }}/{{ zuul.projects['github.com/openstack-k8s-operators/telemetry-operator'].src_dir }}/ci/vars-power-monitoring.

@vyzigold
Copy link
Contributor

I think we should just remove the ceilometer_agent_ipmi from the list of container. Powermonitoring is a standalone feature compared to logging, so we shouldn't expect it to be enabled everytime we test logging.

@elfiesmelfie
Copy link
Collaborator Author

elfiesmelfie commented Feb 18, 2025 •
edited
Loading

I think we should just remove the ceilometer_agent_ipmi from the list of container. Powermonitoring is a standalone feature compared to logging, so we shouldn't expect it to be enabled everytime we test logging.

In that case, we should look into adding this test into the powermonitoring tests, if it isn't already there
EDIT: they're already there

@elfiesmelfie
[ci][common] Use separate play for tests requiring elevated priviledges
e36d53b 
The container tests need elevated permissions to run on the compute nodes.
This is not always going to be the case, so become is added to a separate play to only elevate priviliges for some tests.
@elfiesmelfie elfiesmelfie force-pushed the efoley_logging_add_container_tests branch from 56e5a08 to e36d53b Compare February 18, 2025 13:10
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/e14ef87d13584c99aabddb2667c23c90

❌ openstack-k8s-operators-content-provider FAILURE in 8m 34s
⚠️ functional-tests-on-osp18 SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ functional-logging-tests-osp18 SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ functional-graphing-tests-osp18 SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ functional-metric-verification-tests-osp18 SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider

@elfiesmelfie
Copy link
Collaborator Author

recheck

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/c64465179917436bbdea45651c4f40db

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 26m 05s
❌ functional-tests-on-osp18 FAILURE in 25m 45s
✔️ functional-logging-tests-osp18 SUCCESS in 1h 11m 35s
❌ functional-graphing-tests-osp18 FAILURE in 28m 40s
❌ functional-metric-verification-tests-osp18 FAILURE in 26m 09s

@elfiesmelfie
Copy link
Collaborator Author

recheck

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/19f8dce046f94fa6bcecb9213a3df77d

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 30m 39s
❌ functional-tests-on-osp18 FAILURE in 26m 36s
✔️ functional-logging-tests-osp18 SUCCESS in 1h 14m 11s
❌ functional-graphing-tests-osp18 FAILURE in 27m 31s
❌ functional-metric-verification-tests-osp18 FAILURE in 26m 53s

@mgirgisf
Copy link
Contributor

its the same problem for COO let's wait for this PR to be merged : openstack-k8s-operators/telemetry-operator#621

@elfiesmelfie
Copy link
Collaborator Author

recheck

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/a4e8ea2641694ebc8061a04b2dd60269

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 44m 34s
❌ functional-tests-on-osp18 POST_FAILURE in 1h 23m 18s
❌ functional-logging-tests-osp18 POST_FAILURE in 1h 10m 25s
❌ functional-graphing-tests-osp18 POST_FAILURE in 1h 08m 00s
❌ functional-metric-verification-tests-osp18 POST_FAILURE in 1h 21m 31s

@elfiesmelfie
Copy link
Collaborator Author

recheck

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vyzigold vyzigold vyzigold requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@elfiesmelfie @mgirgisf @vyzigold