-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge Zuul Logging job #113
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some pieces that should be taken out, I think.
I suggest you start by creating a new PR that just adds the common tasks in their own role.
After that, create a PR for the test_logging role (with Depends-On the common_task PR) and then the zuul job (you can reuse this PR) (with a Depends-On on the test_logging PR).
The job won't run on the first two PRs, but the test result from this PR (i.e. "the zuul PR") will be valid for both the "common_tasks PR" and the "test_logging role" PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made updates suggested and associated changes needed.
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/1b0c0c692c4b4ce5bd342521b556b123 ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 27m 12s |
ci/logging_tests_ctlplane.yml
Outdated
changed_when: false | ||
|
||
|
||
- name: "RHOSO-12754" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As far as I know, the custom_logger does not look at play names to find the test ids and therefore determine what to log.
It definitely looks at tasks.
The logger MIGHT look at blocks and report pass/fail if the block name has an ID in it.
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/c31500c78aa243329da4f5edb570f4c1 ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 24m 57s |
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/21a4344a3a7b40e2931b4eb1bce91314 ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 41m 00s |
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/177f9dd6e06547faabd000c2302ea3b2 ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 43m 18s |
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/32877f52508944ecb877af82800c0a98 ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 44m 58s |
made lots of changes and will submit new PR. |
Reopening for testing |
Merge Failed. This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset. |
Merge Failed. This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset. |
I rebased this branch against master. |
76955cc
to
b302395
Compare
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/f9cc04896a584e57b8dad887f4f161bf ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 22m 46s |
This change depends on a change that failed to merge. Change #118 is needed. |
recheck |
0799ffd
to
4156382
Compare
I rebased this against the branch for PR#118 to avoid Zuul complaining |
This change depends on a change that failed to merge. Change #118 is needed. |
The logging plugins we use need all the tests to run in order to report properly. Adding ignore_errors to the plays that run the tests allows all the tests to run even when one fails. Also added verbosity to the ansible config to get more info about the failing tests
* rename loggin_tests_local playbook to logging_tests_controller * Rename vars in ci/logging_tests_compute and loggin_tests_controller
ed77a76
to
2de5d0e
Compare
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/576088e1f68244dc830e28b2fde766b2 ✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 04m 55s |
It was replaced with the hook and the logging_tests_all playbook
common_container_list: | ||
- ceilometer_agent_compute | ||
- ceilometer_agent_ipmi | ||
- node_exporter |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this list is correct
- [glance,image,public] | ||
- [glance,image,internal] | ||
- [neutron,network,public] | ||
- [neutron,network,internal] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As far as I remember list correct/needed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I want to re-work the endpoint tests, but this will be included in: #203, so I'm happy to merge them in the current for as long as the tests pass.
common_node_list: | ||
- edpm-compute-0 | ||
- edpm-compute-1 | ||
- crc |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needed, I think
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was pretty sure we decided to skip the node tests, which is why they're not included on master in the common role
ci/logging_tests_controller.yml
Outdated
common_manifest_test_id: "RHOSO-12677" | ||
common_manifest_list: | ||
- "loki-operator 2" | ||
- "loki-helm-operator 1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
needed, I think
ci/logging_tests_controller.yml
Outdated
- nova-internal | ||
- nova-metadata-internal | ||
- nova-novncproxy-cell1-public | ||
- nova-public |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
needed, should be running
ci/logging_tests_computes.yml
Outdated
- ceilometer_agent_ipmi | ||
- node_exporter | ||
|
||
common_file_test_id: "RHOSO-12754" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The file tests for compute are included in: #206
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/e7d56c3e1ca84dd6bce6a75b1253b86c ✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 07m 11s |
Merge Failed. This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset. |
recheck |
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/4bb75a7c7915472a919d2620c3ca35a7 ✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 13m 46s |
Merge Logging job changes into Master
Depended-On: #123
Depends-On: #124
#Depends-On: #118