Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename tasks for XML reporting #181

Merged
merged 16 commits into from
Jan 31, 2025
Merged

Rename tasks for XML reporting #181

merged 16 commits into from
Jan 31, 2025

Conversation

elfiesmelfie
Copy link
Collaborator

@elfiesmelfie elfiesmelfie commented Nov 27, 2024 •
edited
Loading

Depends-On: #204

mgirgisf
mgirgisf reviewed Nov 28, 2024
View reviewed changes
roles/telemetry_graphing/tasks/cypress_test.yml Outdated
- name: "UI-2 Run Cypress tests to validate dashboards exist"
- name: |
TEST Run Cypress tests to validate dashboards exist
UI-2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
UI-2

roles/telemetry_graphing/tasks/cypress_test.yml Outdated
- name: "UI-3 Check if all Cypress tests passed"
- name: |
TEST Check if all Cypress tests passed
UI-3
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
UI-3

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leonid opened a new PR for this: #182

roles/telemetry_graphing/tasks/verify_url.yml Outdated
- name: "UI-1 Check OpenShift Console URL is accessible"
- name: |
TEST Check OpenShift Console URL is accessible
UI-1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
UI-1

@elfiesmelfie elfiesmelfie force-pushed the efoley_xml_reporting_rename branch from 8e5e13c to 31c359f Compare November 28, 2024 19:01
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/064c53b7a9e747b488998fb84e99991c

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 58m 58s
✔️ functional-tests-on-osp18 SUCCESS in 1h 34m 54s
✔️ functional-logging-tests-osp18 SUCCESS in 1h 10m 03s
✔️ functional-graphing-tests-osp18 SUCCESS in 1h 11m 04s
❌ functional-metric-verification-tests-osp18 FAILURE in 1h 14m 17s

@elfiesmelfie elfiesmelfie force-pushed the efoley_xml_reporting_rename branch 2 times, most recently from 406bda7 to 6f950c0 Compare December 4, 2024 15:00
@elfiesmelfie elfiesmelfie force-pushed the efoley_xml_reporting_rename branch from 6f950c0 to 0230bac Compare December 11, 2024 14:06
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/d347ecdbd95e447b951cde9a3175ebe9

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 47m 43s
✔️ functional-tests-on-osp18 SUCCESS in 1h 34m 57s
✔️ functional-logging-tests-osp18 SUCCESS in 1h 08m 44s
❌ functional-graphing-tests-osp18 FAILURE in 1h 09m 55s
✔️ functional-metric-verification-tests-osp18 SUCCESS in 1h 11m 42s

@elfiesmelfie elfiesmelfie force-pushed the efoley_xml_reporting_rename branch 2 times, most recently from 903fd72 to 3f9bf78 Compare December 11, 2024 20:08
@elfiesmelfie elfiesmelfie force-pushed the efoley_xml_reporting_rename branch from 4a2342b to a28119b Compare January 7, 2025 14:16
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/b9cb413d71014f02bb81669f8ff13f5d

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 38m 39s
✔️ functional-tests-on-osp18 SUCCESS in 1h 40m 19s
❌ functional-logging-tests-osp18 FAILURE in 1h 16m 39s
✔️ functional-graphing-tests-osp18 SUCCESS in 1h 07m 51s
✔️ functional-metric-verification-tests-osp18 SUCCESS in 1h 10m 31s

@elfiesmelfie
Copy link
Collaborator Author

recheck

@elfiesmelfie elfiesmelfie force-pushed the efoley_xml_reporting_rename branch from a28119b to 1472c3a Compare January 8, 2025 17:27
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/b63f843ef7034a1c9193a79a103aeb09

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 08m 22s
✔️ functional-tests-on-osp18 SUCCESS in 1h 38m 38s
❌ functional-logging-tests-osp18 FAILURE in 1h 55m 40s
✔️ functional-graphing-tests-osp18 SUCCESS in 1h 08m 02s
✔️ functional-metric-verification-tests-osp18 SUCCESS in 1h 09m 29s

@elfiesmelfie elfiesmelfie force-pushed the efoley_xml_reporting_rename branch from 1472c3a to 63b9eb3 Compare January 15, 2025 15:32
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/5bb2f21ba2be48d7aa3a5300e2319af4

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 54m 30s
✔️ functional-tests-on-osp18 SUCCESS in 1h 39m 36s
❌ functional-logging-tests-osp18 FAILURE in 1h 06m 02s
✔️ functional-graphing-tests-osp18 SUCCESS in 1h 06m 09s
✔️ functional-metric-verification-tests-osp18 SUCCESS in 1h 04m 19s

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/2e3149e72b5045b7beced193365f826a

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 55m 35s
✔️ functional-tests-on-osp18 SUCCESS in 1h 37m 44s
❌ functional-logging-tests-osp18 FAILURE in 1h 05m 21s
✔️ functional-graphing-tests-osp18 SUCCESS in 1h 04m 24s
❌ functional-metric-verification-tests-osp18 FAILURE in 1h 40m 53s

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/b6050ecc64fe490cacdfdff693f6699e

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 03m 16s
❌ functional-tests-on-osp18 FAILURE in 1h 49m 51s
❌ functional-logging-tests-osp18 FAILURE in 1h 05m 39s
❌ functional-graphing-tests-osp18 FAILURE in 1h 04m 51s
✔️ functional-metric-verification-tests-osp18 SUCCESS in 1h 05m 36s

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/8fce62f5a7354756b402d79f4c35276a

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 05m 16s
❌ functional-tests-on-osp18 FAILURE in 1h 50m 11s
❌ functional-logging-tests-osp18 FAILURE in 33m 40s
❌ functional-graphing-tests-osp18 FAILURE in 1h 03m 21s
✔️ functional-metric-verification-tests-osp18 SUCCESS in 1h 04m 47s

elfiesmelfie
elfiesmelfie commented Jan 20, 2025
View reviewed changes
roles/common/tasks/cr_tests.yml Outdated
run_cr_ready_test: true
when:
- common_cr_ready_test_id is defined
- item.condition_type is defined
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need to add default('false') to this, I think.

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/7ac63966ff024febbabedd09dde1b00d

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 04m 17s
❌ functional-tests-on-osp18 FAILURE in 1h 51m 07s
❌ functional-logging-tests-osp18 FAILURE in 1h 05m 16s
❌ functional-graphing-tests-osp18 FAILURE in 1h 03m 23s
✔️ functional-metric-verification-tests-osp18 SUCCESS in 1h 05m 49s

@elfiesmelfie
Copy link
Collaborator Author

recheck

@elfiesmelfie elfiesmelfie force-pushed the efoley_xml_reporting_rename branch from a8067c6 to 0ee051f Compare January 20, 2025 19:07
ayefimov-1
ayefimov-1 approved these changes Jan 20, 2025
View reviewed changes
Copy link
Contributor

@ayefimov-1 ayefimov-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine. Thx

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/7d1e7261ad76446d87937ccec0e1b818

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 00m 51s
❌ functional-tests-on-osp18 FAILURE in 1h 48m 01s
❌ functional-logging-tests-osp18 FAILURE in 1h 06m 04s
❌ functional-graphing-tests-osp18 FAILURE in 1h 01m 31s
✔️ functional-metric-verification-tests-osp18 SUCCESS in 1h 04m 22s

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Merge Failed.

This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.
Warning:
Error merging github.com/infrawatch/feature-verification-tests for 181,220ff8a12063806c9ca66df9efaa3048491def8a

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Merge Failed.

This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.
Warning:
Error merging github.com/infrawatch/feature-verification-tests for 181,a5ce98f4f307733cb9d8482e5d4fde888e6b28ab

@elfiesmelfie elfiesmelfie force-pushed the efoley_xml_reporting_rename branch from a5ce98f to bd56a6d Compare January 29, 2025 19:36
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Merge Failed.

This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.
Warning:
Error merging github.com/infrawatch/feature-verification-tests for 181,bd56a6dacbafa3fc2939cabfe5fcc30148f75959

@elfiesmelfie elfiesmelfie force-pushed the efoley_xml_reporting_rename branch from bd56a6d to 4b02fac Compare January 30, 2025 11:23
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Merge Failed.

This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.
Warning:
Error merging github.com/infrawatch/feature-verification-tests for 181,4b02fac9ef9ca379dc6bb855d80ad0082e2a14df

@elfiesmelfie elfiesmelfie force-pushed the efoley_xml_reporting_rename branch from 4b02fac to 171ab2c Compare January 30, 2025 11:25
@elfiesmelfie
[common] Fix failure condition in file test
909c44b 
failed_when uses and for list items, and fails only when all conditions are met
@elfiesmelfie
[common][file] Use assert instead of failed_when
c93124a 
This allows more information to be shown about why the test failed.
@elfiesmelfie
[common] Update the CR tests to mark one as optional
c400673 
Only include the test_id if the condition_type is defined.
Set a default for the condition_type so that the task name is rendered
correctly in output plugins.
@elfiesmelfie
[telemetry_logging] Update task names for XML reporting
a58ab0a
@elfiesmelfie
[common] Update task names for XML reporting
0cc0136
@elfiesmelfie
[common] Rename the test for projects
bfd1e85
@elfiesmelfie
[common] Rename the test for pods
2a2a193 
Update the name for the pod tests
* Include the namespace that the pod is running in
* Include the status string

format for the testcase name in snake_case
  check_{{ pod_name }}_pod_is_{{ common_pod_status_str }}_in_{{ namespace }}_namespace
@elfiesmelfie
[ansible-lint] Update the config to ignore templates in task names
17700c3 
name[template]: Jinja templates should only be at the end of 'name'
@elfiesmelfie
[common] Rename file, service and container tests to report the tasks…
a66392c 
… correctly
@elfiesmelfie
[common] Update name for subscription test
381f8dd
@elfiesmelfie
[common] Update task name to follow convention
560af60
@elfiesmelfie
[common] Add test prefix to service tests
bcab28e
@elfiesmelfie
[common] Update endpoint test
ed9057a
@elfiesmelfie
[common] Remove the CR update that adds the optional test
25491b0 
It is addressed in a different commit
@elfiesmelfie elfiesmelfie force-pushed the efoley_xml_reporting_rename branch from 171ab2c to 25491b0 Compare January 30, 2025 15:48
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Merge Failed.

This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.
Warning:
Error merging github.com/infrawatch/feature-verification-tests for 181,25491b059bc675df47bc733ef5b7adce9c4fc4f2

mgirgisf
mgirgisf approved these changes Jan 31, 2025
View reviewed changes
Copy link
Contributor

@mgirgisf mgirgisf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Emma

@elfiesmelfie elfiesmelfie merged commit 4229659 into master Jan 31, 2025
8 checks passed
@elfiesmelfie elfiesmelfie deleted the efoley_xml_reporting_rename branch January 31, 2025 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vyzigold vyzigold vyzigold approved these changes

@mgirgisf mgirgisf mgirgisf approved these changes

@lnatapov lnatapov Awaiting requested review from lnatapov

@myadla myadla Awaiting requested review from myadla

@ayefimov-1 ayefimov-1 Awaiting requested review from ayefimov-1

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@elfiesmelfie @vyzigold @mgirgisf @ayefimov-1