[ID-3696] refactor: move linking wallet example to zkevm api directory #465
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nattb8
force-pushed
the
refactor/link-wallet-zkevmapi
branch
from
a9d802e to
db7f60f
Compare
ImmutableJeffrey
approved these changes
May 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR moves the Link Wallet example from the Passport package to the ZkEvmApi directory. While the example originally lived under Passport, it primarily depends on the ZkEvmApi package for its functionality. The only requirement from Passport is an access token, which can be manually provided by the user if needed.
This change ensures that the sample code in the Passport package (Samples~ folder) remains self-contained and compiles successfully when imported, without requiring users to install the ZkEvmApi package.
Customer Impact
This change improves compatibility by ensuring the Passport sample code (Samples~ folder) works out of the box without requiring the ZkEvmApi package. No breaking changes - the moved example is still available under ZkEvmApi samples (this and this).