Skip to content

fix: missing proto messages for the interface registry #4580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 18, 2025

Conversation

Pantani
Copy link
Collaborator

@Pantani Pantani commented Mar 17, 2025

close #4565

@Pantani Pantani self-assigned this Mar 17, 2025
@Pantani Pantani marked this pull request as ready for review March 17, 2025 23:44
julienrbrt
julienrbrt previously approved these changes Mar 18, 2025
Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK

Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Pantani
Copy link
Collaborator Author

Pantani commented Mar 18, 2025

tACK! However this somehow times out now: https://github.com/ignite/cli/actions/runs/13918585795/job/38946349740?pr=4580

The unit tests are failing due to race conditions sometimes as well

@Pantani Pantani merged commit 4ead07f into main Mar 18, 2025
39 of 45 checks passed
@Pantani Pantani deleted the fix/interface-registry branch March 18, 2025 13:02
@julienrbrt
Copy link
Member

tACK! However this somehow times out now: https://github.com/ignite/cli/actions/runs/13918585795/job/38946349740?pr=4580

The unit tests are failing due to race conditions sometimes as well

it looks like it happens all the time and not occasionally after this PR actually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FIX: data is not passing to the CLI client
2 participants