Skip to content

Commit a6431bd

Browse files
authored
Merge branch 'main' into fix/interface-registry
2 parents 5d96fe9 + e65f86e commit a6431bd

File tree

4 files changed

+5
-8
lines changed

4 files changed

+5
-8
lines changed

Diff for: changelog.md

+1
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@
1414

1515
- [#4565](https://github.com/ignite/cli/issues/4565) Fix missing proto messages for the interface registry.
1616
- [#4577](https://github.com/ignite/cli/pull/4577) Add proto version to query path.
17+
- [#4579](https://github.com/ignite/cli/pull/4579) Fix empty params response.
1718

1819
## [`v29.0.0-beta.1`](https://github.com/ignite/cli/releases/tag/v29.0.0-beta.1)
1920

Diff for: go.mod

+1-1
Original file line numberDiff line numberDiff line change
@@ -155,7 +155,7 @@ require (
155155
github.com/cockroachdb/tokenbucket v0.0.0-20230807174530-cc333fc44b06 // indirect
156156
github.com/cometbft/cometbft-db v0.14.1 // indirect
157157
github.com/containerd/cgroups/v3 v3.0.5 // indirect
158-
github.com/containerd/containerd v1.7.25 // indirect
158+
github.com/containerd/containerd v1.7.27 // indirect
159159
github.com/containerd/continuity v0.4.5 // indirect
160160
github.com/containerd/errdefs v1.0.0 // indirect
161161
github.com/containerd/errdefs/pkg v0.3.0 // indirect

Diff for: go.sum

+2-2
Original file line numberDiff line numberDiff line change
@@ -484,8 +484,8 @@ github.com/containerd/cgroups/v3 v3.0.5 h1:44na7Ud+VwyE7LIoJ8JTNQOa549a8543BmzaJ
484484
github.com/containerd/cgroups/v3 v3.0.5/go.mod h1:SA5DLYnXO8pTGYiAHXz94qvLQTKfVM5GEVisn4jpins=
485485
github.com/containerd/console v1.0.1/go.mod h1:XUsP6YE/mKtz6bxc+I8UiKKTP04qjQL4qcS3XoQ5xkw=
486486
github.com/containerd/console v1.0.3/go.mod h1:7LqA/THxQ86k76b8c/EMSiaJ3h1eZkMkXar0TQ1gf3U=
487-
github.com/containerd/containerd v1.7.25 h1:khEQOAXOEJalRO228yzVsuASLH42vT7DIo9Ss+9SMFQ=
488-
github.com/containerd/containerd v1.7.25/go.mod h1:tWfHzVI0azhw4CT2vaIjsb2CoV4LJ9PrMPaULAr21Ok=
487+
github.com/containerd/containerd v1.7.27 h1:yFyEyojddO3MIGVER2xJLWoCIn+Up4GaHFquP7hsFII=
488+
github.com/containerd/containerd v1.7.27/go.mod h1:xZmPnl75Vc+BLGt4MIfu6bp+fy03gdHAn9bz+FreFR0=
489489
github.com/containerd/continuity v0.4.5 h1:ZRoN1sXq9u7V6QoHMcVWGhOwDFqZ4B9i5H6un1Wh0x4=
490490
github.com/containerd/continuity v0.4.5/go.mod h1:/lNJvtJKUQStBzpVQ1+rasXO1LAWtUQssk28EZvJ3nE=
491491
github.com/containerd/errdefs v1.0.0 h1:tg5yIfIlQIrxYtu9ajqY42W3lpS19XqdxRQeEwYG8PI=

Diff for: ignite/templates/module/create/files/base/x/{{moduleName}}/keeper/query_params.go.plush

+1-5
Original file line numberDiff line numberDiff line change
@@ -18,11 +18,7 @@ func (q queryServer) Params(ctx context.Context, req *types.QueryParamsRequest)
1818
}
1919

2020
params, err := q.k.Params.Get(ctx)
21-
if err != nil {
22-
if errors.Is(err, collections.ErrNotFound) {
23-
return nil, status.Error(codes.NotFound, "not found")
24-
}
25-
21+
if err != nil && !errors.Is(err, collections.ErrNotFound) {
2622
return nil, status.Error(codes.Internal, "internal error")
2723
}
2824

0 commit comments

Comments
 (0)