fix(pyspark): generate IF NOT EXISTS if force=True
#10782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
tests
cpcloud
added
bug
We were using the wrong keyword in `sqlglot` for this so it was being swallowed silently.
cpcloud
force-pushed
the
pyspark_exists
branch
from
3b47a7a to
97e68e9
Compare
cpcloud
approved these changes
Feb 4, 2025
|
Looks like we're making this same mistake in MySQL as well. I'll PR that in a sec. |
|
@gforsyth Does this fix the issue you xref'd? Or are you just noting that they are related? If it does fix it, let's add the |
|
No, there's something else going on in that issue but it's why I came across this bug |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
We were using the wrong keyword in
sqlglotfor this so it was beingswallowed silently.
Issues closed
xref #10749