Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(mysql): generate IF NOT EXISTS if force=True #10785

Merged
merged 1 commit into from
Feb 4, 2025
Merged

fix(mysql): generate IF NOT EXISTS if force=True #10785

merged 1 commit into from
Feb 4, 2025

Conversation

cpcloud
Copy link
Member

@cpcloud cpcloud commented Feb 4, 2025

Same bug as #10782, but MySQL edition.

@cpcloud cpcloud added this to the 10.0 milestone Feb 4, 2025
@cpcloud cpcloud added bug Incorrect behavior inside of ibis tests Issues or PRs related to tests ddl Issues related to creating or altering data definitions mysql The MySQL backend labels Feb 4, 2025
@cpcloud cpcloud requested a review from gforsyth February 4, 2025 11:41
gforsyth
gforsyth approved these changes Feb 4, 2025
View reviewed changes
Copy link
Member

@gforsyth gforsyth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@cpcloud cpcloud merged commit d613b55 into ibis-project:main Feb 4, 2025
95 checks passed
@cpcloud cpcloud deleted the mysql-exists branch February 4, 2025 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gforsyth gforsyth gforsyth approved these changes

Assignees
No one assigned
Labels
bug Incorrect behavior inside of ibis ddl Issues related to creating or altering data definitions mysql The MySQL backend tests Issues or PRs related to tests
Projects
None yet
Milestone
10.0
Development

Successfully merging this pull request may close these issues.
2 participants
@cpcloud @gforsyth