fix(backends): ensure that analytic functions do not receive a window frame #10739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpcloud
added
bug
github-actions
bot
added
tests
ibis-docs-bot
bot
removed
the
ci-run-cloud
cpcloud
force-pushed
the
fix-bigquery-windows
branch
from
dd93db8 to
7a7d883
Compare
|
This turns out to be an issue on a number of existing backends, and I fixed as many as I could fix easily. |
|
So far, ClickHouse and MySQL are the outliers: their analytic function behavior seems to differ when given a window frame clause. |
|
Ok, I think I managed to address clickhouse and mysql as well. Working on the impala snapshots now. |
cpcloud
force-pushed
the
fix-bigquery-windows
branch
from
35c8f79 to
c8471d3
Compare
cpcloud
added
clickhouse
cpcloud
force-pushed
the
fix-bigquery-windows
branch
from
c8471d3 to
fe0cd56
Compare
cpcloud
added
the
ci-run-cloud
ibis-docs-bot
bot
removed
ci-run-cloud
cpcloud
force-pushed
the
fix-bigquery-windows
branch
2 times, most recently
from
a19c3b5 to
876c2f4
Compare
cpcloud
force-pushed
the
fix-bigquery-windows
branch
from
876c2f4 to
96214df
Compare
|
Ok, this turned out to address a good chunk of the inconsistency with window function behavior across backends. We're not at 100% consistency, but this is a decent improvement. |
gforsyth
approved these changes
Jan 28, 2025
gforsyth
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10699.