fix(backends): fix most remaining backends ordered sum

ibis/backends/impala/tests/snapshots/test_analytic_functions/test_analytic_exprs/first/out.sql

@@ -1,3 +1,3 @@
 SELECT
-  FIRST_VALUE(`t0`.`double_col`) OVER (ORDER BY `t0`.`id` ASC) AS `First(double_col, ())`
+  FIRST_VALUE(`t0`.`double_col`) OVER (ORDER BY `t0`.`id` ASC ROWS BETWEEN UNBOUNDED PRECEDING AND UNBOUNDED FOLLOWING) AS `First(double_col, ())`
 FROM `functional_alltypes` AS `t0`

ibis/backends/impala/tests/snapshots/test_analytic_functions/test_analytic_exprs/last/out.sql

@@ -1,3 +1,3 @@
 SELECT
-  LAST_VALUE(`t0`.`double_col`) OVER (ORDER BY `t0`.`id` ASC) AS `Last(double_col, ())`
+  LAST_VALUE(`t0`.`double_col`) OVER (ORDER BY `t0`.`id` ASC ROWS BETWEEN UNBOUNDED PRECEDING AND UNBOUNDED FOLLOWING) AS `Last(double_col, ())`
 FROM `functional_alltypes` AS `t0`

ibis/backends/impala/tests/snapshots/test_sql/test_group_by_with_window_preserves_range/out.sql

@@ -1 +1 @@
-SELECT `t0`.`one`, `t0`.`two`, `t0`.`three`, SUM(`t0`.`two`) OVER (PARTITION BY `t0`.`three` ORDER BY `t0`.`one` ASC) AS `four` FROM `my_data` AS `t0`
+SELECT `t0`.`one`, `t0`.`two`, `t0`.`three`, SUM(`t0`.`two`) OVER (PARTITION BY `t0`.`three` ORDER BY `t0`.`one` ASC ROWS BETWEEN UNBOUNDED PRECEDING AND CURRENT ROW) AS `four` FROM `my_data` AS `t0`

ibis/backends/impala/tests/snapshots/test_window/test_add_default_order_by/out.sql

@@ -12,7 +12,7 @@ SELECT
   `t0`.`k`,
   LAG(`t0`.`f`) OVER (PARTITION BY `t0`.`g` ORDER BY NULL ASC) AS `lag`,
   LEAD(`t0`.`f`) OVER (PARTITION BY `t0`.`g` ORDER BY NULL ASC) - `t0`.`f` AS `fwd_diff`,
-  FIRST_VALUE(`t0`.`f`) OVER (PARTITION BY `t0`.`g` ORDER BY NULL ASC) AS `first`,
-  LAST_VALUE(`t0`.`f`) OVER (PARTITION BY `t0`.`g` ORDER BY NULL ASC) AS `last`,
+  FIRST_VALUE(`t0`.`f`) OVER (PARTITION BY `t0`.`g` ORDER BY NULL ASC ROWS BETWEEN UNBOUNDED PRECEDING AND UNBOUNDED FOLLOWING) AS `first`,
+  LAST_VALUE(`t0`.`f`) OVER (PARTITION BY `t0`.`g` ORDER BY NULL ASC ROWS BETWEEN UNBOUNDED PRECEDING AND UNBOUNDED FOLLOWING) AS `last`,
   LAG(`t0`.`f`) OVER (PARTITION BY `t0`.`g` ORDER BY `t0`.`d` ASC) AS `lag2`
 FROM `alltypes` AS `t0`

ibis/backends/impala/tests/snapshots/test_window/test_aggregate_in_projection/out.sql

@@ -10,5 +10,5 @@ SELECT
   `t0`.`i`,
   `t0`.`j`,
   `t0`.`k`,
-  `t0`.`f` / SUM(`t0`.`f`) OVER (ORDER BY NULL ASC) AS `normed_f`
+  `t0`.`f` / SUM(`t0`.`f`) OVER (ORDER BY NULL ASC ROWS BETWEEN UNBOUNDED PRECEDING AND UNBOUNDED FOLLOWING) AS `normed_f`
 FROM `alltypes` AS `t0`

ibis/backends/impala/tests/snapshots/test_window/test_cumulative_functions/max/out1.sql

@@ -1,3 +1,3 @@
 SELECT
-  MAX(`t0`.`f`) OVER (ORDER BY `t0`.`d` ASC) AS `foo`
+  MAX(`t0`.`f`) OVER (ORDER BY `t0`.`d` ASC ROWS BETWEEN UNBOUNDED PRECEDING AND CURRENT ROW) AS `foo`
 FROM `alltypes` AS `t0`

ibis/backends/impala/tests/snapshots/test_window/test_cumulative_functions/max/out2.sql

@@ -1,3 +1,3 @@
 SELECT
-  MAX(`t0`.`f`) OVER (ORDER BY `t0`.`d` ASC) AS `foo`
+  MAX(`t0`.`f`) OVER (ORDER BY `t0`.`d` ASC ROWS BETWEEN UNBOUNDED PRECEDING AND CURRENT ROW) AS `foo`
 FROM `alltypes` AS `t0`

ibis/backends/impala/tests/snapshots/test_window/test_cumulative_functions/mean/out1.sql

@@ -1,3 +1,3 @@
 SELECT
-  AVG(`t0`.`f`) OVER (ORDER BY `t0`.`d` ASC) AS `foo`
+  AVG(`t0`.`f`) OVER (ORDER BY `t0`.`d` ASC ROWS BETWEEN UNBOUNDED PRECEDING AND CURRENT ROW) AS `foo`
 FROM `alltypes` AS `t0`

ibis/backends/impala/tests/snapshots/test_window/test_cumulative_functions/mean/out2.sql

@@ -1,3 +1,3 @@
 SELECT
-  AVG(`t0`.`f`) OVER (ORDER BY `t0`.`d` ASC) AS `foo`
+  AVG(`t0`.`f`) OVER (ORDER BY `t0`.`d` ASC ROWS BETWEEN UNBOUNDED PRECEDING AND CURRENT ROW) AS `foo`
 FROM `alltypes` AS `t0`

ibis/backends/impala/tests/snapshots/test_window/test_cumulative_functions/min/out1.sql

@@ -1,3 +1,3 @@
 SELECT
-  MIN(`t0`.`f`) OVER (ORDER BY `t0`.`d` ASC) AS `foo`
+  MIN(`t0`.`f`) OVER (ORDER BY `t0`.`d` ASC ROWS BETWEEN UNBOUNDED PRECEDING AND CURRENT ROW) AS `foo`
 FROM `alltypes` AS `t0`

ibis/backends/impala/tests/snapshots/test_window/test_cumulative_functions/min/out2.sql

@@ -1,3 +1,3 @@
 SELECT
-  MIN(`t0`.`f`) OVER (ORDER BY `t0`.`d` ASC) AS `foo`
+  MIN(`t0`.`f`) OVER (ORDER BY `t0`.`d` ASC ROWS BETWEEN UNBOUNDED PRECEDING AND CURRENT ROW) AS `foo`
 FROM `alltypes` AS `t0`

ibis/backends/impala/tests/snapshots/test_window/test_cumulative_functions/sum/out1.sql

@@ -1,3 +1,3 @@
 SELECT
-  SUM(`t0`.`f`) OVER (ORDER BY `t0`.`d` ASC) AS `foo`
+  SUM(`t0`.`f`) OVER (ORDER BY `t0`.`d` ASC ROWS BETWEEN UNBOUNDED PRECEDING AND CURRENT ROW) AS `foo`
 FROM `alltypes` AS `t0`

ibis/backends/impala/tests/snapshots/test_window/test_cumulative_functions/sum/out2.sql

@@ -1,3 +1,3 @@
 SELECT
-  SUM(`t0`.`f`) OVER (ORDER BY `t0`.`d` ASC) AS `foo`
+  SUM(`t0`.`f`) OVER (ORDER BY `t0`.`d` ASC ROWS BETWEEN UNBOUNDED PRECEDING AND CURRENT ROW) AS `foo`
 FROM `alltypes` AS `t0`

ibis/backends/impala/tests/snapshots/test_window/test_multiple_windows/out.sql

@@ -1,4 +1,4 @@
 SELECT
   `t0`.`g`,
-  SUM(`t0`.`f`) OVER (PARTITION BY `t0`.`g` ORDER BY NULL ASC) - SUM(`t0`.`f`) OVER (ORDER BY NULL ASC) AS `result`
+  SUM(`t0`.`f`) OVER (PARTITION BY `t0`.`g` ORDER BY NULL ASC ROWS BETWEEN UNBOUNDED PRECEDING AND UNBOUNDED FOLLOWING) - SUM(`t0`.`f`) OVER (ORDER BY NULL ASC ROWS BETWEEN UNBOUNDED PRECEDING AND UNBOUNDED FOLLOWING) AS `result`
 FROM `alltypes` AS `t0`

ibis/backends/impala/tests/snapshots/test_window/test_order_by_desc/out2.sql

@@ -1,4 +1,4 @@
 SELECT
   LAG(`t0`.`d`) OVER (PARTITION BY `t0`.`g` ORDER BY `t0`.`f` DESC NULLS LAST) AS `foo`,
-  MAX(`t0`.`a`) OVER (PARTITION BY `t0`.`g` ORDER BY `t0`.`f` DESC NULLS LAST) AS `Max(a)`
+  MAX(`t0`.`a`) OVER (PARTITION BY `t0`.`g` ORDER BY `t0`.`f` DESC NULLS LAST ROWS BETWEEN UNBOUNDED PRECEDING AND UNBOUNDED FOLLOWING) AS `Max(a)`
 FROM `alltypes` AS `t0`

ibis/backends/impala/tests/snapshots/test_window/test_window_frame_specs/cumulative/out.sql

@@ -1,3 +1,3 @@
 SELECT
-  SUM(`t0`.`d`) OVER (ORDER BY `t0`.`f` ASC) AS `foo`
+  SUM(`t0`.`d`) OVER (ORDER BY `t0`.`f` ASC ROWS BETWEEN UNBOUNDED PRECEDING AND CURRENT ROW) AS `foo`
 FROM `alltypes` AS `t0`

ibis/backends/impala/tests/snapshots/test_window/test_window_frame_specs/foll_0/out.sql

@@ -1,3 +1,3 @@
 SELECT
-  SUM(`t0`.`d`) OVER (ORDER BY `t0`.`f` ASC) AS `foo`
+  SUM(`t0`.`d`) OVER (ORDER BY `t0`.`f` ASC ROWS BETWEEN UNBOUNDED PRECEDING AND CURRENT ROW) AS `foo`
 FROM `alltypes` AS `t0`

ibis/backends/sql/compilers/clickhouse.py

@@ -119,17 +119,6 @@ class ClickHouseCompiler(SQLGlotCompiler):
         ops.RandomScalar: "randCanonical",
     }
 
-    @staticmethod
-    def _minimize_spec(op, spec):
-        if (
-            op.start is None
-            and isinstance(getattr(end := op.end, "value", None), ops.Literal)
-            and end.value.value == 0
-            and end.following
-        ):
-            return None
-        return spec
-
     def visit_Cast(self, op, *, arg, to):
         _interval_cast_suffixes = {
             "s": "Second",

ibis/backends/sql/compilers/mysql.py

@@ -102,11 +102,8 @@ def POS_INF(self):
 
     @staticmethod
     def _minimize_spec(op, spec):
-        if (
-            op.start is None
-            and isinstance(getattr(end := op.end, "value", None), ops.Literal)
-            and end.value.value == 0
-            and end.following
+        if isinstance(
+            op.func, (ops.RankBase, ops.CumeDist, ops.NTile, ops.PercentRank)
         ):
             return None
         return spec

ibis/backends/tests/snapshots/test_sql/test_mixed_qualified_and_unqualified_predicates/impala/out.sql

@@ -5,11 +5,11 @@ FROM (
   SELECT
     `t1`.`x`,
     `t1`.`y`,
-    AVG(`t1`.`x`) OVER (ORDER BY NULL ASC) AS _w
+    AVG(`t1`.`x`) OVER (ORDER BY NULL ASC ROWS BETWEEN UNBOUNDED PRECEDING AND UNBOUNDED FOLLOWING) AS _w
   FROM (
     SELECT
       `t0`.`x`,
-      SUM(`t0`.`x`) OVER (ORDER BY NULL ASC) AS `y`
+      SUM(`t0`.`x`) OVER (ORDER BY NULL ASC ROWS BETWEEN UNBOUNDED PRECEDING AND UNBOUNDED FOLLOWING) AS `y`
     FROM `t` AS `t0`
   ) AS `t1`
   WHERE

ibis/backends/tests/test_window.py

@@ -664,11 +664,6 @@ def test_simple_ungrouped_window_with_scalar_order_by(alltypes):
             True,
             id="ordered-mean",
             marks=[
-                pytest.mark.notimpl(
-                    ["impala"],
-                    reason="default window semantics are different",
-                    raises=AssertionError,
-                ),
                 pytest.mark.notimpl(
                     ["risingwave"],
                     raises=PsycoPg2InternalError,
@@ -1250,7 +1245,7 @@ def test_windowed_order_by_sequence_is_preserved(con):
     reason="window functions aren't yet implemented for the polars backend",
 )
 @pytest.mark.notimpl(
-    ["clickhouse", "flink", "mysql"],
+    ["flink"],
     raises=AssertionError,
     reason="default behavior is the same as bigquery and hasn't been addressed",
 )