Skip to content

Conversation

zguesmi
Copy link
Member

@zguesmi zguesmi commented Jul 7, 2025

This PR cleans the makefile and removes the current implementation of upgrade scripts because scripts are intended to be used on live networks and for production, it does not make sens to use mock files in them.

@codecov
Copy link

codecov bot commented Jul 7, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (main@03ba891). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #73   +/-   ##
=======================================
  Coverage        ?   83.78%           
=======================================
  Files           ?        4           
  Lines           ?      111           
  Branches        ?        7           
=======================================
  Hits            ?       93           
  Misses          ?       17           
  Partials        ?        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zguesmi zguesmi self-assigned this Jul 7, 2025
@zguesmi zguesmi marked this pull request as ready for review July 7, 2025 18:47
Base automatically changed from feature/createx-deployment-for-impl to main July 8, 2025 07:25
Copy link
Contributor

@Le-Caignec Le-Caignec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Capture d’écran 2025-07-08 à 11 26 36 `vm.getCode` only looks for code in the src folder. This breaks all our upgrade scripts that rely on mock files for upgrades.

run : make upgrade-on-anvil

@zguesmi
Copy link
Member Author

zguesmi commented Oct 6, 2025

vm.getCode only looks for code in the src folder. This breaks all our upgrade scripts that rely on mock files for upgrades.
run : make upgrade-on-anvil

@Le-Caignec see the PR description.

@zguesmi zguesmi marked this pull request as ready for review October 6, 2025 14:57
@zguesmi zguesmi requested review from Le-Caignec and Copilot October 6, 2025 14:57
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Refactors project structure to move mock contracts under test directories and disables mock-based upgrade scripts to avoid accidental use in production workflows. Also renames several Makefile targets and aligns documentation references accordingly.

  • Relocated mock imports to point to src instead of previous relative mock paths
  • Disabled Upgrade scripts by replacing logic with a reverting stub
  • Renamed Makefile targets (e.g., upgrade-* and send-tokens-*) and updated README/docs accordingly

Reviewed Changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
test/units/mocks/RLCLiquidityUnifierV2Mock.sol Updated import path to source contract
test/units/mocks/IexecLayerZeroBridgeV2Mock.sol Updated import path to source contract
test/units/bridges/layerZero/IexecLayerZeroBridgeUpgradeScript.t.sol Adjusted mock import path for test usage
test/units/RLCLiquidityUnifierUpgrade.t.sol Reordered/updated import to relocated mock
script/bridges/layerZero/IexecLayerZeroBridge.s.sol Removed live upgrade logic; now reverts
script/SendFromEthereumToArbitrum.s.sol Clarified network scope in comment
script/SendFromArbitrumToEthereum.s.sol Clarified network scope in comment
script/RLCLiquidityUnifier.s.sol Removed live upgrade logic; now reverts
script/RLCCrosschainToken.s.sol Added placeholder Upgrade contract that reverts
docs/soldoc/src/README.md Updated Make targets references
README.md Updated Make targets references
Makefile Reorganized deployment/upgrade/config targets; renamed and added targets

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@zguesmi zguesmi merged commit 627c937 into main Oct 13, 2025
4 checks passed
@zguesmi zguesmi deleted the feature/mock-cleaning branch October 13, 2025 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants