-
Notifications
You must be signed in to change notification settings - Fork 0
refactor: Move mock files to test folder #73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #73 +/- ##
=======================================
Coverage ? 83.78%
=======================================
Files ? 4
Lines ? 111
Branches ? 7
=======================================
Hits ? 93
Misses ? 17
Partials ? 1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Le-Caignec see the PR description. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Refactors project structure to move mock contracts under test directories and disables mock-based upgrade scripts to avoid accidental use in production workflows. Also renames several Makefile targets and aligns documentation references accordingly.
- Relocated mock imports to point to src instead of previous relative mock paths
- Disabled Upgrade scripts by replacing logic with a reverting stub
- Renamed Makefile targets (e.g., upgrade-* and send-tokens-*) and updated README/docs accordingly
Reviewed Changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 1 comment.
Show a summary per file
File | Description |
---|---|
test/units/mocks/RLCLiquidityUnifierV2Mock.sol | Updated import path to source contract |
test/units/mocks/IexecLayerZeroBridgeV2Mock.sol | Updated import path to source contract |
test/units/bridges/layerZero/IexecLayerZeroBridgeUpgradeScript.t.sol | Adjusted mock import path for test usage |
test/units/RLCLiquidityUnifierUpgrade.t.sol | Reordered/updated import to relocated mock |
script/bridges/layerZero/IexecLayerZeroBridge.s.sol | Removed live upgrade logic; now reverts |
script/SendFromEthereumToArbitrum.s.sol | Clarified network scope in comment |
script/SendFromArbitrumToEthereum.s.sol | Clarified network scope in comment |
script/RLCLiquidityUnifier.s.sol | Removed live upgrade logic; now reverts |
script/RLCCrosschainToken.s.sol | Added placeholder Upgrade contract that reverts |
docs/soldoc/src/README.md | Updated Make targets references |
README.md | Updated Make targets references |
Makefile | Reorganized deployment/upgrade/config targets; renamed and added targets |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This PR cleans the makefile and removes the current implementation of upgrade scripts because scripts are intended to be used on live networks and for production, it does not make sens to use mock files in them.