feat: add unit tests for internal _credit function
#62
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…etup in TestUtils
Le-Caignec
changed the title
_mint function
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #62 +/- ##
==========================================
+ Coverage 79.80% 83.65% +3.84%
==========================================
Files 4 4
Lines 104 104
Branches 7 7
==========================================
+ Hits 83 87 +4
+ Misses 20 16 -4
Partials 1 1 ☔ View full report in Codecov by Sentry. |
Le-Caignec
commented
Jul 3, 2025
Comment on lines
-25
to
-26
| string public name = "iEx.ec Network Token"; | ||
| string public symbol = "RLC"; |
There was a problem hiding this comment.
Adding those two string memory variables into our utils library caused a Stack too Deep issue. So the library needs to be refactored to use a struct and to improve storage management.
Le-Caignec
changed the title
_mint function_credit function
Le-Caignec
commented
Jul 4, 2025
Le-Caignec
requested review from
gfournieriExec and
zguesmi
and removed request for
zguesmi
zguesmi
reviewed
Jul 4, 2025
…rZeroBridge _credit tests
…s-for-_mint-function
…s-for-_mint-function
…by using deploy scripts
zguesmi
reviewed
Jul 8, 2025
Co-authored-by: Zied Guesmi <[email protected]>
Co-authored-by: Zied Guesmi <[email protected]>
zguesmi
reviewed
Jul 8, 2025
zguesmi
reviewed
Jul 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.