Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: split sonar to its own config #13

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@ This package includes the following configurations:
- [`eslint-config-neon/react`](./src/react.ts) – for usage with [React](https://reactjs.org/).
- [`eslint-config-neon/rxjs`](./src/rxjs.ts) – for usage with [RxJS](https://rxjs.dev/).
- [`eslint-config-neon/rxjs-angular`](./src/rxjs-angular.ts) – for usage [RxJS](https://rxjs.dev/) and [Angular](https://angular.io/).
- [`eslint-config-neon/sonar`](./src/sonar.ts) – ESLint rules that match [The Sonar Way](https://rules.sonarsource.com/javascript).
- [`eslint-config-neon/svelte`](./src/svelte.ts) – for usage with [Svelte](https://svelte.dev/).
- [`eslint-config-neon/svelte-typescript`](./src/svelte-typescript.ts) – for usage with [Svelte](https://svelte.dev/) and [TypeScript](http://typescriptlang.org/).
- [`eslint-config-neon/typescript`](./src/typescript.ts) – for usage with [TypeScript](http://typescriptlang.org/).
Expand Down
12 changes: 11 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -197,6 +197,16 @@
"default": "./dist/cjs/rxjs.cjs"
}
},
"./sonar": {
"import": {
"types": "./dist/esm/sonar.d.mts",
"default": "./dist/esm/sonar.mjs"
},
"require": {
"types": "./dist/cjs/sonar.d.cts",
"default": "./dist/cjs/sonar.cjs"
}
},
"./svelte-typescript": {
"import": {
"types": "./dist/esm/svelte-typescript.d.mts",
Expand Down Expand Up @@ -323,4 +333,4 @@
"node": "^18.18.0 || ^20.9.0 || >=21.1.0"
},
"packageManager": "[email protected]"
}
}
1 change: 1 addition & 0 deletions src/index.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
export { default as angular } from "./angular";

Check failure on line 1 in src/index.ts

View workflow job for this annotation

GitHub Actions / Validate Generated Index

File did not match generated file after script. Please review and adjust accordingly.
export { default as astro } from "./astro";
export { default as browser } from "./browser";
export { default as common } from "./common";
Expand All @@ -15,6 +15,7 @@
export { default as react } from "./react";
export { default as rxjs } from "./rxjs";
export { default as rxjsangular } from "./rxjs-angular";
export { default as sonar } from "./sonar";
export { default as svelte } from "./svelte";
export { default as sveltetypescript } from "./svelte-typescript";
export { default as typescript } from "./typescript";
Expand Down
47 changes: 47 additions & 0 deletions src/sonar.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,47 @@
import type { TSESLint } from "@typescript-eslint/utils";
import eslintPluginSonarjs from "eslint-plugin-sonarjs";

const rules: TSESLint.FlatConfig.Rules = {
"sonarjs/no-all-duplicated-branches": 2,
"sonarjs/no-element-overwrite": 2,
"sonarjs/no-empty-collection": 2,
"sonarjs/no-extra-arguments": 2,
"sonarjs/no-identical-conditions": 2,
"sonarjs/no-identical-expressions": 2,
"sonarjs/no-ignored-return": 2,
"sonarjs/no-one-iteration-loop": 2,
"sonarjs/no-use-of-empty-return-value": 2,
"sonarjs/non-existent-operator": 2,
"sonarjs/elseif-without-else": 0,
"sonarjs/max-switch-cases": 0,
"sonarjs/no-collapsible-if": 2,
"sonarjs/no-collection-size-mischeck": 2,
"sonarjs/no-duplicate-string": 0,
"sonarjs/no-duplicated-branches": 2,
"sonarjs/no-gratuitous-expressions": 2,
"sonarjs/no-identical-functions": 2,
"sonarjs/no-inverted-boolean-check": 2,
"sonarjs/no-nested-switch": 2,
"sonarjs/no-nested-template-literals": 0,
"sonarjs/no-redundant-boolean": 2,
"sonarjs/no-redundant-jump": 2,
"sonarjs/no-same-line-conditional": 2,
"sonarjs/no-small-switch": 0,
"sonarjs/no-unused-collection": 2,
"sonarjs/no-useless-catch": 0,
"sonarjs/prefer-immediate-return": 2,
"sonarjs/prefer-object-literal": 2,
"sonarjs/prefer-single-boolean-return": 2,
"sonarjs/prefer-while": 2,
};

const config: TSESLint.FlatConfig.ConfigArray = [
{
plugins: {
sonarjs: eslintPluginSonarjs,
},
rules,
},
];

export default config;
33 changes: 0 additions & 33 deletions src/typescript.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
import { fixupPluginRules } from "@eslint/compat";
import type { TSESLint } from "@typescript-eslint/utils";
import eslintPluginSonarjs from "eslint-plugin-sonarjs";
import eslintPluginTsdoc from "eslint-plugin-tsdoc";
// @ts-expect-error eslint-plugin-typescript-sort-keys is not typed
import eslintPluginTypescriptSortKeys from "eslint-plugin-typescript-sort-keys";
Expand Down Expand Up @@ -334,37 +333,6 @@ const rules: TSESLint.FlatConfig.Rules = {
"jsdoc/require-property-type": 0,
"no-undef": 0,
"n/global-require": 0,
"sonarjs/no-all-duplicated-branches": 2,
"sonarjs/no-element-overwrite": 2,
"sonarjs/no-empty-collection": 2,
"sonarjs/no-extra-arguments": 2,
"sonarjs/no-identical-conditions": 2,
"sonarjs/no-identical-expressions": 2,
"sonarjs/no-ignored-return": 2,
"sonarjs/no-one-iteration-loop": 2,
"sonarjs/no-use-of-empty-return-value": 2,
"sonarjs/non-existent-operator": 2,
"sonarjs/elseif-without-else": 0,
"sonarjs/max-switch-cases": 0,
"sonarjs/no-collapsible-if": 2,
"sonarjs/no-collection-size-mischeck": 2,
"sonarjs/no-duplicate-string": 0,
"sonarjs/no-duplicated-branches": 2,
"sonarjs/no-gratuitous-expressions": 2,
"sonarjs/no-identical-functions": 2,
"sonarjs/no-inverted-boolean-check": 2,
"sonarjs/no-nested-switch": 2,
"sonarjs/no-nested-template-literals": 0,
"sonarjs/no-redundant-boolean": 2,
"sonarjs/no-redundant-jump": 2,
"sonarjs/no-same-line-conditional": 2,
"sonarjs/no-small-switch": 0,
"sonarjs/no-unused-collection": 2,
"sonarjs/no-useless-catch": 0,
"sonarjs/prefer-immediate-return": 2,
"sonarjs/prefer-object-literal": 2,
"sonarjs/prefer-single-boolean-return": 2,
"sonarjs/prefer-while": 2,
"tsdoc/syntax": 1,
"typescript-sort-keys/interface": 2,
"typescript-sort-keys/string-enum": 2,
Expand Down Expand Up @@ -392,7 +360,6 @@ const settings: TSESLint.FlatConfig.Settings = {

const config: TSESLint.FlatConfig.ConfigArray = tseslint.config(...tseslint.configs.recommended, {
plugins: {
sonarjs: eslintPluginSonarjs,
tsdoc: eslintPluginTsdoc,
"typescript-sort-keys": fixupPluginRules(eslintPluginTypescriptSortKeys),
},
Expand Down
Loading