Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: split sonar to its own config #13

Closed
wants to merge 1 commit into from

Conversation

favna
Copy link
Contributor

@favna favna commented Nov 25, 2024

Please describe the changes this PR makes and why it should be merged:

TL;DR: I want to be able to not load the sonarjs plugin

Sonarlint plugin is giving lots of trouble because the versions of their dependencies is behind neon, in particular typescript-eslint being v7 with sonar. This is giving lots of conflicting dependencies issues. I'm also getting issues relating to Sonar forcing a dependency of for example eslint-plugin-react despite the project not needing or configuring React. Even if I allow Yarn to pull in all dependencies and not skip anything I still get this error now:

Oops! Something went wrong! :(

ESLint: 9.15.0

TypeError: Cannot read properties of undefined (reading 'meta')
    at decorate (/Users/favna/workspace/favware/discord-application-emojis-manager/node_modules/eslint-plugin-sonarjs/cjs/S1116/decorator.js:12:65)
    at Object.<anonymous> (/Users/favna/workspace/favware/discord-application-emojis-manager/node_modules/eslint-plugin-sonarjs/cjs/S1116/index.js:25:44)
    at Module._compile (node:internal/modules/cjs/loader:1546:14)
    at Object..js (node:internal/modules/cjs/loader:1689:10)
    at Module.load (node:internal/modules/cjs/loader:1318:32)
    at Function._load (node:internal/modules/cjs/loader:1128:12)
    at TracingChannel.traceSync (node:diagnostics_channel:315:14)
    at wrapModuleLoad (node:internal/modules/cjs/loader:218:24)
    at Module.require (node:internal/modules/cjs/loader:1340:12)
    at require (node:internal/modules/helpers:141:16)

@favna
Copy link
Contributor Author

favna commented Nov 25, 2024

Looks like this was mostly a fluke of local setup.

@favna favna closed this Nov 25, 2024
@favna favna deleted the refactor/sonar-own-config branch November 25, 2024 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant