Skip to content

feature(ci): Add GHA to check go mod tidy on PR #1067

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 31, 2025
Merged

feature(ci): Add GHA to check go mod tidy on PR #1067

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 16 additions & 1 deletion .github/workflows/git.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,23 @@ on: [pull_request]
jobs:
block-fixup:
runs-on: ubuntu-latest

steps:
- uses: actions/checkout@v5
- name: Block Fixup Commit Merge
uses: 13rac1/[email protected]

go-mod-tidy:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v5
- uses: actions/setup-go@v6
with:
go-version-file: "go.mod"
Copy link
Contributor

@AkramBitar AkramBitar Oct 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed that we have more than one go.mod file in FSC:
fabric-smart-client (main) $ find . -name "go.mod"
./platform/fabric/services/state/cc/query/go.mod
./go.mod
./tools/go.mod

Does the check done recursively or we need to check only the one in the root?

Copy link
Member Author

@mbrandenburger mbrandenburger Oct 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make tidy runs go mod tidy in all those directories.

cache-dependency-path: "**/*.sum"
- run: make tidy
- name: Check for diffs
run: |
git diff --exit-code || {
echo "Please run 'make tidy' and commit the changes";
exit 1;
}