feature(ci): Add GHA to check go mod tidy on PR #1067
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marcus Brandenburger <[email protected]>
|
@AkramBitar I guess this could also be useful for FTS -- please feel free to borrow the GHA script. |
AkramBitar
reviewed
Oct 30, 2025
| - uses: actions/checkout@v5 | ||
| - uses: actions/setup-go@v6 | ||
| with: | ||
| go-version-file: "go.mod" |
There was a problem hiding this comment.
I noticed that we have more than one go.mod file in FSC:
fabric-smart-client (main) $ find . -name "go.mod"
./platform/fabric/services/state/cc/query/go.mod
./go.mod
./tools/go.mod
Does the check done recursively or we need to check only the one in the root?
There was a problem hiding this comment.
make tidy runs go mod tidy in all those directories.
AkramBitar
approved these changes
Oct 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces a GHA to check that a PR comes with a clean go.mod/sum.