-
Notifications
You must be signed in to change notification settings - Fork 63
Move adapters to http-body-util
#56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I think we should merge this @g2p probably worth a force push/fresh commit to trigger CI then we can review/merge? |
Sure, reworded something and force pushed. I think the CI runs require maintainer approval. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks mostly good. That said, can we also move http-body
into its own folder?
Both crates have their own folders now. |
This looks good. It aligns with what is written in the hyper roadmap. My question now is, since this is a "breaking change" to |
imo we should merge this to master and start working towards 1.0 there. We can always make a |
Yea, lets create a |
@g2p can you resolve the conflicts and then we can merge this! thanks. |
Hyper works with all combinators removed, as would anything that depends on the initial 0.4 release. Removing methods from the trait is a breaking change, but it is possible to do the semver trick (release 0.5, then release 0.4.x with a dependency on the 0.5 trait) to not split the ecosystem. Addresses hyperium#52.
@LucioFranco done! |
Thanks!!! |
Move utilities and combinators to a separate package
Hyper works with all combinators removed, as would anything that depends on the initial 0.4 release.
Removing methods from the trait is a breaking change, but it is possible to do the semver trick (release 0.5, then release 0.4.x with a dependency on the 0.5 trait) to not split the ecosystem and make the change painless.
Addresses #52.