Skip to content

feat: add Limited body #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 20, 2022
Merged

feat: add Limited body #61

merged 3 commits into from
May 20, 2022

Conversation

neoeinstein
Copy link
Contributor

This should be compared to the implementation in #60.

@neoeinstein
Copy link
Contributor Author

I removed the const generic from my implementation, but of note it does mean that Default can no longer be implemented for this body type like it is for both Full and Empty. I'm not 100% sure of the value of the Default implementation, but if it's not necessary, then the non-generic version should be fine.

@davidpdrsn davidpdrsn mentioned this pull request May 20, 2022
Closed
@LucioFranco
Copy link
Member

@davidpdrsn @seanmonstar is this something we'd like to release in 0.4? aka should we merge this before #56

@davidpdrsn
Copy link
Member

davidpdrsn commented May 20, 2022 •
edited
Loading

I would appreciate that yes. Wanna make a middleware in tower-http to go along with this.

davidpdrsn
davidpdrsn reviewed May 20, 2022
View reviewed changes
davidpdrsn
davidpdrsn reviewed May 20, 2022
View reviewed changes
@davidpdrsn davidpdrsn merged commit e17465c into hyperium:master May 20, 2022
@davidpdrsn davidpdrsn mentioned this pull request May 20, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidpdrsn davidpdrsn davidpdrsn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@neoeinstein @LucioFranco @davidpdrsn