Add root parameter to training script. Use --dataset.root_dir to set root dir #690
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves issue #689.
What this does
Adds a root_dir parameter to the datasetConfig class which determines which parameters are accepted in the train.py script.
The make_dataset factory configuration was modified as well to actually use the parameter.
How it was tested
Data was recorded with a different root path.
Then the training was run with the new root dir specified and the training succesfully started. Before this implementation an error was thrown showing the user's home directory being used to search for the dataset.
Examples:
Notes
-I'm unsure if the changes I made will impact the library in other areas like recording and evaluation because I changed the dataclass of the datasetconfig. If I find any issues I will submit as part of a separate pull request with the assumption this one is accepted.