Log images to Rerun as Dynamic instead of Static content #2103
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this does
before this PR
Rerun would only log a single image. Saving the recording wouldn't provide the rest of the video. This means that if you save the recording, you only get that single starting frame.
after this PR
Rerun will show / log all the images. so that if the sure saves the recording, you will have all of those images recorded.
How it was tested
Manually, but I work at Rerun.
How to checkout & try? (for the reviewer)
Very simple, run teleop, it will open Rerun.

Save the recording.
Open that recording with
rerun path-to-recording.rrd
Rather than a single image, it will show all of the images, up to the buffered amount.