Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cosmos library #1089

Merged
merged 2 commits into from
Jan 8, 2025
Merged

Add cosmos library #1089

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b89d20f
Add cosmos library
pcuenca Jan 7, 2025
4831851
Remove filter
pcuenca Jan 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions packages/tasks/src/model-libraries.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,6 +166,13 @@ export const MODEL_LIBRARIES_UI_ELEMENTS = {
filter: false,
countDownloads: `path:"adapter_config.json"`,
},
cosmos: {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated to this PR but are these models supposed to be usable with Nemo ? Since they are tagged as "nemo", there is a "use this model" snippet in all of them but with empty snippets. This is due to the fact that the nemo code snippet generator is incomplete (see here

huggingface.js/packages/tasks/src/model-libraries-snippets.ts

Line 1082 in 504fcb4

export const nemo = (model: ModelData): string[] => {
and

huggingface.js/packages/tasks/src/model-libraries-snippets.ts

Line 959 in 504fcb4

const nemoDomainResolver = (domain: string, model: ModelData): string[] | undefined => {
). @Haoxiang-Wang @pcuenca would it make sense to open a separate PR to complete the snippets?

prettyLabel: "Cosmos",
repoName: "Cosmos",
repoUrl: "https://github.com/NVIDIA/Cosmos",
filter: false,
countDownloads: `path:"config.json" OR path_extension:"pt"`,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pcuenca Aren't we counting download twice here? I've checked repos under https://huggingface.co/models?other=cosmos and they seem to have the config.json file. And a lot have a model.pt file while others have .pth files in subdirectories. Any way we could update the download count rule to account for all differences ?

},
"cxr-foundation": {
prettyLabel: "CXR Foundation",
repoName: "cxr-foundation",
Expand Down
Loading