-
Notifications
You must be signed in to change notification settings - Fork 317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cosmos library #1089
Add cosmos library #1089
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Thanks! Should be much more easier to have snippets once/ if in transformers.
Thank you @pcuenca ! I am the Cosmos team member who is in charge of our model uploading to Hugging Face Hub. I noticed most of our Cosmos-1.0 models have no download statistics counted yet (see the screenshot below), which concerns us. @Vaibhavs10 @julien-c Please merge this MR as soon as possible, and I will tag all Cosmos-1.0 models with the ![]() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Haoxiang-Wang - It should merge today, note after the PR is merged and after a deployment. It'd take 24-48 hours for download counters to come in effect.
and, yes, please do update the library_name
to cosmos
🤗
Thanks for the confirmation @Haoxiang-Wang, merging now. This is an example PR to update the repos: https://huggingface.co/nvidia/Cosmos-1.0-Diffusion-7B-Text2World/discussions/1/files |
prettyLabel: "Cosmos", | ||
repoName: "Cosmos", | ||
repoUrl: "https://github.com/NVIDIA/Cosmos", | ||
countDownloads: `path:"config.json" OR path_extension:"pt"`, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pcuenca Aren't we counting download twice here? I've checked repos under https://huggingface.co/models?other=cosmos and they seem to have the config.json
file. And a lot have a model.pt
file while others have .pth
files in subdirectories. Any way we could update the download count rule to account for all differences ?
@@ -166,6 +166,12 @@ export const MODEL_LIBRARIES_UI_ELEMENTS = { | |||
filter: false, | |||
countDownloads: `path:"adapter_config.json"`, | |||
}, | |||
cosmos: { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unrelated to this PR but are these models supposed to be usable with Nemo ? Since they are tagged as "nemo", there is a "use this model" snippet in all of them but with empty snippets. This is due to the fact that the nemo code snippet generator is incomplete (see here
export const nemo = (model: ModelData): string[] => { |
const nemoDomainResolver = (domain: string, model: ModelData): string[] | undefined => { |
Hi @Wauplin, we took a quick look with @ariG23498 to create a Cosmos-based snippet, but it was not immediately obvious so we decided to tackle it later. Happy to revisit! I believe that the compatibility with nemo in some of these models comes from the existence of a Other models, however, do not contain a Additional guidance from @Haoxiang-Wang would be super helpful here. |
Ok, thanks for the context. About I'm also inclined to split repos if a models has different file structure for different libraries. |
This enables downloads once these models are assigned the
cosmos
library. Snippets can come later.