Attach Develocity build scans to GitHub Checks #227
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yrodiere
changed the title
yrodiere
force-pushed
the
develocity-build-scans
branch
3 times, most recently
from
1adb3c8 to
67dc5bc
Compare
yrodiere
force-pushed
the
develocity-build-scans
branch
from
67dc5bc to
db96059
Compare
|
There's definitely room for improvement, but it looks like we have the basics covered. So, I'll merge. Feel free to suggest improvements here or sending pull requests, @sebersole @beikov @gsmet @marko-bekhta! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #223
Note the main advantage over Develocity's own stuff (a GitHub Action I think?), which is used on Quarkus, is that this feature works for both GitHub Actions and Jenkins, and reports all build scans in a single check. From what I've seen, Develocity's stuff only lists GitHub Actions build scans on GitHub, and Jenkins build scans on Jenkins.
This also gives us flexibility in the format, e.g. to include tags, so I guess that's a win as well.
See here how it looks:
hibernate/hibernate-github-bot-playground#13
https://github.com/hibernate/hibernate-github-bot-playground/runs/22930448183