Enable build scans and build cache in Jenkinsfile and list build scans in a GitHub check #8016
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note you won't see the Develocity check in this PR, because only the bot config from the |
yrodiere
force-pushed
the
develocity-bot
branch
from
430b3f5 to
64000ba
Compare
|
Sorry -- much better if I actually push all the commits :] |
Using hibernate-github-bot.
It doesn't seem to work as we get "JOB null" on every build scan. Even if it worked, it would most likely only display the top-level job, e.g. `hibernate-orm-pipeline` on Jenkins, which doesn't give much information.
yrodiere
force-pushed
the
develocity-bot
branch
from
64000ba to
7c7d549
Compare
|
Wow, nice! Looking... |
|
So, looks like Gradle's Develocity integration does not add the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Oddly, it seems the build cache and, more annoyingly, build scans, were not enabled in the Jenkinsfile. So this fixes that. Note that for pull requests, we use a different access key which is not able to push to the build cache -- for security reasons.
Also, this enables a new feature in hibernate-github-bot that basically adds a GitHub check next to the existing ones for GitHub Actions or Jenkins, and inside that check is a list of build scans, along with some context (tags, ...).
Note this works best when build scans are tagged properly, e.g. you add a
postgresqltag to CI runs against postgresql. So I adjusted GitHub Actions workflows and the Jenkinsfile accordingly.See hibernate/hibernate-github-bot#227