Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support arbitrary launch process commands #67

Merged
merged 4 commits into from
Mar 20, 2025

Conversation

runesoerensen
Copy link
Contributor

@runesoerensen runesoerensen commented Mar 19, 2025

This PR changes how the launch.toml is parsed, to allow arbitrary process command lists (while retaining the current special handling for bash processes):

  • The behavior for launch.toml command definitions like ["bash", "-c", "cd foobar/; ./foobar"] is unchanged. The third argument is used to define the process used by this buildpack (e.g. when detecting default process types in bin/release).
  • Commands that do not rely on bash wrapping are now supported by the launch.toml parser. Every argument is checked for special characters, and double-quoted as needed.
  • This prepares the buildpack to support these changes: Refactor test launch process definition buildpacks-dotnet#240.

Also see these related discussions:

This changes the launch.toml parsing to allow arbitrary `command` lists, while maintaining the current special handling for bash command arguments
@runesoerensen runesoerensen merged commit 40db110 into main Mar 20, 2025
5 checks passed
@runesoerensen runesoerensen deleted the support-arbitrary-launch-process-commands branch March 20, 2025 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants