Unquote default process type commands #69
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR simply removes the quotes around process commands from the output produced by
bin/release
. This is inconsequential for all currently supported uses of the buildpack.However, the recently adopted CNB changes to support paths with spaces won't work as expected in the following scenario:
CNB_EXEC_ENV
config var is set totest
.Which results in
bin/release
output like this:This is very much an unsupported use case currently, as
launch.toml
processes used bybin/release
never contains double quotes (when targeting theproduction
execution environment), and the argument quoting introduced by #67 only affectslaunch.toml
parsing used inbin/test
.It's of course still worth fixing as the command quoting in
bin/release
is unnecessary / not required by neither theProcfile
nor the Buildpack API specs. It's also quite likely that the CNB will producelaunch.toml
processes differently in the future, e.g. to supportDevelopment
execution environments.