Skip to content

Implement methods of interface Node #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 22 commits into from
Jun 6, 2021
Merged

Implement methods of interface Node #32

merged 22 commits into from
Jun 6, 2021

Conversation

hepheir
Copy link
Owner

@hepheir hepheir commented Jun 6, 2021

No description provided.

hepheir added 22 commits June 4, 2021 11:16
@hepheir
Create method has_child_nodes() (#16)
122b77e
@hepheir
Create method insert_before() (#16)
fac414d
@hepheir
Update parent_node parameters of Node.__init__ (#16)
59f56ba 
the `parent_node` cannot be set directly on constructor.

since the parent node should have self in its `child_nodes`.
the binding of parent-child nodes can be done with `insert_before`, `append_child` methods.
@hepheir
Update owner_document parameters of Node.__init__ (#16)
44cbde2 
A `Document` object; `owner_document` must be given when creating a `Node`.

But if this node is a `Document`, `owner_document` is `None`.
@hepheir
Remove method Node._check_modifiable() (#16)
35a5143
@hepheir
Create method Node.append_child() (#16)
ed53b54
@hepheir
Update unittests (#16, #17)
a5b7656
@hepheir
#16 Add unittest for Node.parent_node setter.
c5e0cc9
@hepheir
#16 Add unittest for Node.append_child()
3384e8d
@hepheir
#16 Disable linter for intended errors in unittest
25edea3
@hepheir
#16 Fix for failed unittest of Node.append_child()
ec6f7f9 
failed test: `test_AppendExistingChild()`
@hepheir
#16 Create method Node.replace_child()
f51f5a9
@hepheir
#16 Add comment for Node.insert_before()
7c5ed53
@hepheir
#16 Add comment for Node.append_child()
2fcf3a0
@hepheir
#16 Add comments; DOM structure prepared for unit testing
ddb9675
@hepheir
#16 Create method Node.remove_child()
db81502
@hepheir
#16 Create method Node.clone_node().
2e78547 
and its accessor methods; `Node._shallow_copy()` and `Node._deep_copy()`
@hepheir
#16 Create unittest for Node.has_child_nodes()
243c96d
@hepheir
#16 Rename test classes and test methods
70a4885 
class name: `Test<Type>_<MethodName>`
method name: `test_<StateOrParams>`
@hepheir
Use TestCase.setUp() for prepraing each test cases.
2cfc7c5
@hepheir
Use with statement rather than try ... except for unit testing.
74d7f7d
@hepheir
Open an issue Make a unittest for Node.clone_node() #31
42fb184
@hepheir hepheir self-assigned this Jun 6, 2021
@hepheir hepheir added the enhancement New feature or request label Jun 6, 2021
@hepheir hepheir marked this pull request as ready for review June 6, 2021 11:47
@hepheir hepheir linked an issue Jun 6, 2021 that may be closed by this pull request
Implement interface Node #16
Closed
17 tasks
@hepheir hepheir merged commit e51b7dc into master Jun 6, 2021
@hepheir hepheir deleted the Hepheir/issue16 branch June 6, 2021 11:48
@hepheir hepheir added type:others issues not falling in bug, perfromance, support, build and install or feature and removed enhancement New feature or request labels Jun 7, 2021
@hepheir hepheir added type:feature Feature requests and removed type:others issues not falling in bug, perfromance, support, build and install or feature labels Jun 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@hepheir hepheir

Labels
type:feature Feature requests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement interface Node
1 participant
@hepheir