Skip to content

Implement interface Node #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
17 tasks done
hepheir opened this issue Jun 2, 2021 · 1 comment · Fixed by #22 or #32
Closed
17 tasks done

Implement interface Node #16

hepheir opened this issue Jun 2, 2021 · 1 comment · Fixed by #22 or #32
Assignees
@hepheir
Labels
type:feature Feature requests

Comments

@hepheir
Copy link
Owner

hepheir commented Jun 2, 2021 •
edited
Loading

https://www.w3.org/TR/REC-DOM-Level-1/level-one-core.html#ID-1950641247

Interface Node

IDL Definition

More 
interface Node {
  // NodeType
  const unsigned short      ELEMENT_NODE       = 1;
  const unsigned short      ATTRIBUTE_NODE     = 2;
  const unsigned short      TEXT_NODE          = 3;
  const unsigned short      CDATA_SECTION_NODE = 4;
  const unsigned short      ENTITY_REFERENCE_NODE = 5;
  const unsigned short      ENTITY_NODE        = 6;
  const unsigned short      PROCESSING_INSTRUCTION_NODE = 7;
  const unsigned short      COMMENT_NODE       = 8;
  const unsigned short      DOCUMENT_NODE      = 9;
  const unsigned short      DOCUMENT_TYPE_NODE = 10;
  const unsigned short      DOCUMENT_FRAGMENT_NODE = 11;
  const unsigned short      NOTATION_NODE      = 12;

  readonly attribute  DOMString            nodeName;
           attribute  DOMString            nodeValue;
                                                 // raises(DOMException) on setting
                                                 // raises(DOMException) on retrieval
  readonly attribute  unsigned short       nodeType;
  readonly attribute  Node                 parentNode;
  readonly attribute  NodeList             childNodes;
  readonly attribute  Node                 firstChild;
  readonly attribute  Node                 lastChild;
  readonly attribute  Node                 previousSibling;
  readonly attribute  Node                 nextSibling;
  readonly attribute  NamedNodeMap         attributes;
  readonly attribute  Document             ownerDocument;
  Node                      insertBefore(in Node newChild, 
                                         in Node refChild)
                                         raises(DOMException);
  Node                      replaceChild(in Node newChild, 
                                         in Node oldChild)
                                         raises(DOMException);
  Node                      removeChild(in Node oldChild)
                                        raises(DOMException);
  Node                      appendChild(in Node newChild)
                                        raises(DOMException);
  boolean                   hasChildNodes();
  Node                      cloneNode(in boolean deep);
};

Attributes

  • readonly attribute DOMString nodeName
  • attribute DOMString nodeValue
  • readonly attribute unsigned short nodeType
  • readonly attribute Node parentNode
  • readonly attribute NodeList childNodes
  • readonly attribute Node firstChild
  • readonly attribute Node lastChild
  • readonly attribute Node previousSibling
  • readonly attribute Node nextSibling
  • readonly attribute NamedNodeMap attributes
  • readonly attribute Document ownerDocument

Methods

  • Node insertBefore(in Node newChild, in Node refChild)
  • Node replaceChild(in Node newChild, in Node oldChild)
  • Node removeChild(in Node oldChild)
  • Node appendChild(in Node newChild)
  • boolean hasChildNodes()
  • Node cloneNode(in boolean deep)
@hepheir hepheir self-assigned this Jun 2, 2021
@hepheir hepheir changed the title Implement interface Node Implement interface Node Jun 2, 2021
hepheir added a commit that referenced this issue Jun 2, 2021
@hepheir
Create readonly attributes previous_sibling, next_sibling
e7e7f94 
also create accessor method `_nth_child_of_parent()`

#16
@hepheir hepheir added the enhancement New feature or request label Jun 2, 2021
hepheir added a commit that referenced this issue Jun 3, 2021
@hepheir
Create readonly attribute attributes #16
6edfd99 
TODO: Implement interface `NamedNodeMap` #19
hepheir added a commit that referenced this issue Jun 3, 2021
@hepheir
Create readonly attribute owner_document (#16)
9c18ce3 
with its accessor `_set_owner_document()`
and declared `_Document` for typing temporarily (TODO, #20)
@hepheir hepheir linked a pull request Jun 3, 2021 that will close this issue
Implement of Node's properties (#16) #22
Merged
hepheir added a commit that referenced this issue Jun 3, 2021
@hepheir
Merge pull request #22 from Hepheir/Hepheir/issue16
9e233fd 
Implement of `Node`'s properties (#16)
@hepheir hepheir reopened this Jun 3, 2021
@hepheir
Copy link
Owner Author

hepheir commented Jun 3, 2021

아직 메소드들이 구현되지 않음

hepheir added a commit that referenced this issue Jun 4, 2021
@hepheir
Create method has_child_nodes() (#16)
122b77e
hepheir added a commit that referenced this issue Jun 4, 2021
@hepheir
Create method insert_before() (#16)
fac414d
hepheir added a commit that referenced this issue Jun 4, 2021
@hepheir
Update parent_node parameters of Node.__init__ (#16)
59f56ba 
the `parent_node` cannot be set directly on constructor.

since the parent node should have self in its `child_nodes`.
the binding of parent-child nodes can be done with `insert_before`, `append_child` methods.
hepheir added a commit that referenced this issue Jun 4, 2021
@hepheir
Update owner_document parameters of Node.__init__ (#16)
44cbde2 
A `Document` object; `owner_document` must be given when creating a `Node`.

But if this node is a `Document`, `owner_document` is `None`.
hepheir added a commit that referenced this issue Jun 4, 2021
@hepheir
Remove method Node._check_modifiable() (#16)
35a5143
hepheir added a commit that referenced this issue Jun 4, 2021
@hepheir
Create method Node.append_child() (#16)
ed53b54
hepheir added a commit that referenced this issue Jun 4, 2021
@hepheir
Update unittests (#16, #17)

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
a186503
hepheir added a commit that referenced this issue Jun 6, 2021
@hepheir
Update unittests (#16, #17)

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
a5b7656
hepheir added a commit that referenced this issue Jun 6, 2021
@hepheir
#16 Add unittest for Node.parent_node setter.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
c5e0cc9
hepheir added a commit that referenced this issue Jun 6, 2021
@hepheir
#16 Add unittest for Node.append_child()

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
3384e8d
hepheir added a commit that referenced this issue Jun 6, 2021
@hepheir
#16 Disable linter for intended errors in unittest

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
25edea3
hepheir added a commit that referenced this issue Jun 6, 2021
@hepheir
#16 Fix for failed unittest of Node.append_child()

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
ec6f7f9 
failed test: `test_AppendExistingChild()`
hepheir added a commit that referenced this issue Jun 6, 2021
@hepheir
#16 Create method Node.replace_child()

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
f51f5a9
hepheir added a commit that referenced this issue Jun 6, 2021
@hepheir
#16 Add comment for Node.insert_before()

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
7c5ed53
hepheir added a commit that referenced this issue Jun 6, 2021
@hepheir
#16 Add comment for Node.append_child()
2fcf3a0
hepheir added a commit that referenced this issue Jun 6, 2021
@hepheir
#16 Add comments; DOM structure prepared for unit testing
ddb9675
hepheir added a commit that referenced this issue Jun 6, 2021
@hepheir
#16 Create method Node.remove_child()
db81502
hepheir added a commit that referenced this issue Jun 6, 2021
@hepheir
#16 Create method Node.clone_node().
2e78547 
and its accessor methods; `Node._shallow_copy()` and `Node._deep_copy()`
hepheir added a commit that referenced this issue Jun 6, 2021
@hepheir
#16 Create unittest for Node.has_child_nodes()
243c96d
hepheir added a commit that referenced this issue Jun 6, 2021
@hepheir
#16 Rename test classes and test methods
70a4885 
class name: `Test<Type>_<MethodName>`
method name: `test_<StateOrParams>`
@hepheir hepheir linked a pull request Jun 6, 2021 that will close this issue
Implement methods of interface Node #32
Merged
@hepheir hepheir added type:others issues not falling in bug, perfromance, support, build and install or feature type:feature Feature requests and removed enhancement New feature or request type:others issues not falling in bug, perfromance, support, build and install or feature labels Jun 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hepheir hepheir

Labels
type:feature Feature requests
Projects
None yet
Milestone
No milestone
1 participant
@hepheir