Implement of Node's properties (#16)
#22
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Start Implementing `Node` * Add definition group `NodeType` * Create class constructor * Add readonly attribute `node_type` * Add readonly attribute `node_name` (abstract) * Add protected boolean attribute `_read_only` * Add attribute `node_value` (abstract) * Add readonly attribute `parent_node` also create a method * `_set_parent_node()` * Add readonly attribute `child_nodes` * Add readonly attributes `first_child`, `last_child` * Add readonly attributes `previous_sibling`, `next_sibling` * Add readonly attribute `attributes` (abstract) * Add readonly attribute `owner_document`
* Start implementing NodeList * Make class `NodeList` more list-like by inheriting `list` * Add readonly attribute `length` * Add method `item`
To prevent pylint(import-error) `pylint --generate-rcfile > .pylintrc`
* Create fundamental_interface.py * Create DOMException.py * Create definition group `ExceptionCode` * Create `DOMException` which inherits from `ExceptionCode` and `Exception` * Bind `DOMException` to `w3.python.core.fundamental_interfaces` * Fix TypeError: "cannot extend enumerations" * Bind `DOMException` to `w3.python.dom` and `w3.python.core` * Create unittest for `DOMException` * Rename dir "fundamental_interfaces" -> "fundamental_interface' of "w3/python/core/"
* Create DOMImplementation.py * Create interface `DOMImplementation` * Create `has_feature` method but not fully implemented * Bind `DOMImplementation` to `w3.python.dom`
(cherry picked from commit 0903a8c)
with its accessor method `_set_node_value()`
with its accessor method `_set_node_type()`
found by unittest
when `node` is an instance of `Node()` Yes: `node.node_value` No: `node._node_value`
`NO_MODIFICATION_ALLOWED_ERR`
...to make Python extension of VSCode to discover unittests. (cherry picked from commit c147e3f)
* Create NodeList.py * Implement `NodeList` based on `list` type * Create unittest for `NodeList`
and its accessor method `_init_child_nodes()`
Related issue: Implement of interface NodeList #17
commit 7307b2d Author: Hepheir <[email protected]> Date: Wed Jun 2 01:19:42 2021 +0900 Remove all except `DOMString` commit e9134ff Author: Hepheir <[email protected]> Date: Mon May 31 20:48:17 2021 +0900 Change the type of `DOMString` from `TypeVar` into `str` Related issues: - Implement of `DOMString` type #18
also create accessor method `_nth_child_of_parent()` #16
TODO: Implement interface `NamedNodeMap` #19
with its accessor `_set_owner_document()` and declared `_Document` for typing temporarily (TODO, #20)
Closed
17 tasks
hepheir
added
type:others
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
노드 구현 과정에서 다음의 인터페이스도 함께 구현되었습니다.
DOMString(ImplementDOMStringtype #18)DOMException(ImplementDOMException#21)DOMImplementation(Implement interfaceDOMImplementation#13)NodeList(Implement interfaceNodeList#17)