Makes name and schema optional in #[table] macro.
#8
+24
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When you don't specify which schema to use, it falls back to using the `public` schema. Likewise, when you don't specify the table name, it will simply use the name of the struct.
|
I like it! Especially the optional schema is a good idea. I do think it is good to be explicit about the table name here though |
cdbrkfxrpt
added a commit
that referenced
this pull request
Feb 3, 2024
cdbrkfxrpt
added a commit
that referenced
this pull request
Feb 8, 2024
* Guard schema for when not using SQLite * Remove feature from macros in anticipation of #8 * Revert import merging --------- Co-authored-by: Florian Eich <[email protected]>
|
I don't think there is a real reason for this so I'm closing the PR for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This one is more of an idea:
When you don't specify which schema to use, it falls back to using the
publicschema. Likewise, when you don't specify the table name, it will simply use the name of the struct.Todo
snake_casethe name of the struct?rename = "UPPER_CASE"here?publicschema string a const?